keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
372 stars 102 forks source link

chore(common): Add `minimum-versions.inc.sh` #11380

Closed ermshiperete closed 1 week ago

ermshiperete commented 1 week ago

This file contains the minimal required versions as discussed for Keyman 18.

Implements #11371.

@keymanapp-test-bot skip

keymanapp-test-bot[bot] commented 1 week ago

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

mcdurdin commented 1 week ago

One more thought: this is also the ideal place, in comments, to document reasoning behind min versions. If we put reasoning elsewhere, it will diverge...

ermshiperete commented 1 week ago

I am not sure what the DEFAULT_UBUNTU_VERSION is for (and it would be nice it could show a version number in the comments for comparison since you used a name here).

That's bleeding through from an upcoming PR. It's the default Ubuntu version used in Docker containers. I renamed it, maybe that makes it clearer.

keyman-server commented 1 week ago

Changes in this pull request will be available for download in Keyman version 18.0.32-alpha