darcywong00 commented 1 week ago

Start of 18.0 chore in updating Android dependencies (including Sentry 7.8.0). These dev dependencies require no change to CI (still using JDK 11).

Fixes #11370 in minor increment from 7.4.0 to 7.4.2 of the Android gradle plugin.

Updating to Gradle 8.0 will require a lot more work in also updating JDK to 17 and handling Robolectric changes.

Robolectric also recommends migrating to AndroidX Test at some point https://robolectric.org/androidx_test/

At some point the Robolectric equivalents will be deprecated and removed.

Some of the code changes are because the Gradle update linter enforces super.onBackPressed() to be called.

User Testing

Setup - Install the PR builds of the Android apps for the corresponding tests

TEST_KEYMAN - Verifies back functionality on Keyman
1. Install the PR build of Keyman for Android
2. From the "Get Started" menu, install a second keyboard (khmer_angkor)
3. Verify the khmer_angkor keyboard installs fine
4. Longpress on the globe key to bring up the keyboard picker
5. From the navigation bar, hit the back button
6. Verify Keyboard picker is dismissed and returns to the Keyman app
7. From Keyman, go to Settings --> Installed Languages --> Central Khmer --> Dictionary to display the Dictionary picker
8. From the navigation bar, hit the back button
9. Verify the Central Khmer Settings page is displayed
10. From the navigation bar, hit the back button
11. Verify the Installed Languages page is displayed
12. From the navigation bar, hit the back button
13. Verify the Settings page is displayed
14. From the navigation bar, hit the back button
15. Verify the Keyman app is displayed
TEST_FV - Verifies the back functionality of the FirstVoices for Android app
1. Install the PR build of Firstvoices for Android
2. From the setup menu, install a keyboard
3. From the setup menu, then select "Select Keyboard" -->BC Coast --> SENCOTEN --> to bring up SENCOTEN Settings
4. From the navigation bar, hit the back button
5. Verify the BC Coast page is displayed
6. From the navigation bar, hit the back button
7. Verify the Regions page is displayed

keymanapp-test-bot[bot] commented 1 week ago

User Test Results

✅ TEST_KEYMAN (PASSED): I tested this issue with the attached "Keyman 18.0.31-alpha-test-11393" build on an Android 14 environment: Here is my observation. (notes)
✅ TEST_FV (PASSED): I tested this issue with the attached "firstvoices 18.0.31-alpha-test-11393" build on an Android 14 environment: Here is my observation. (notes)

darcywong00 commented 1 week ago

18.0 doesn't have all the current reverse selection fixes, so I was able to generate a crash report to Sentry (7.8.0) https://keyman.sentry.io/issues/4263303750

dinakaranr commented 1 week ago

TEST_KEYMAN (PASSED): I tested this issue with the attached "Keyman 18.0.31-alpha-test-11393" build on an Android 14 environment: Here is my observation.
1. Installed the "keyman-18.0.31.apk" file and gave all permissions to the application.
2. Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard box on the settings page.
3. Installed the "Khmer_angkor" keyboard as second.
4. The appropriate pages appear correctly when hitting the back button on the navigation bar. It works well. There is no problem with this behavior.
TEST_FV (PASSED): I tested this issue with the attached "firstvoices 18.0.31-alpha-test-11393" build on an Android 14 environment: Here is my observation.
1. Installed the "keyman-18.0.31.apk" file and installed the keyboard from the setup menu.
2. Enabled the "Sencoten" keyboard.
3. The appropriate pages appear correctly when hitting the back button on the navigation bar. It works well. There is no problem with this behavior.

keyman-server commented 6 days ago

Changes in this pull request will be available for download in Keyman version 18.0.34-alpha