Closed mcdurdin closed 4 months ago
This is happening due to inconsistency in the tsconfig.json compilerOptions
between web and common/web/types. Specifically, in this instance, allowJs
diverges from the global default:
The problem seems to be that tsc --build
in common/web/keyboard-processor
will attempt to build common/web/types
using the settings from common/web/keyboard-processor/tsconfig.json
.
How best to resolve this? I can see various strategies we could use:
compilerOptions
overrides across all tsconfig.json
files. This is a good long-term solution, as it simplifies our build environment, but it may be difficult to pull off.allowJs
property from web/tsconfig.base.json
and the build then succeeded, but it may cause other problems?If memory serves, the allowJs
was originally in place due to its interaction with emitting .d.ts
files; there was a point where TS would refuse to emit declaration files if allowJS
were true
. We're past that point now, and it appears that no build errors resulted - that would be the only potential complication I'd worry about here.
Regression arising from #11660. Causing builds to fail on master, which suggests a potential confict with #11424?