search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
387 stars 107 forks source link

refactor(web): `common/models/*` → `web/src/engine/predictive-text/*` #12133

Closed ermshiperete closed 2 days ago

ermshiperete commented 1 month ago

common/models/types is used by kmc-model. common/models/templates and common/models/wordbreakers are used for tests in kmc-model. Therefore it was decided to not move common/models.

ermshiperete commented 3 weeks ago

Since these are only used in unit tests in Developer, templates and wordbreakers should still be moved. common/model/types has to stay in common.

ermshiperete commented 3 weeks ago

common/model/types should be part of common/web/types. See also #12046.

common/model/types is used by kmc-model, but kmc and kmc-model-info don't seem to use even though it's imported.