Open mcdurdin opened 2 months ago
It may be wise to not highlight the suggestion in this case.
Some things worth note toward fixing this:
The function responsible for doing highlighting:
Here's where auto-selected suggestions are told to highlight:
This may also be mildly relevant:
My initial thoughts toward a solution:
this.suggestion
holds the banner suggestion element's backing Suggestion
object.tag == 'keep'
and .autoAccept == true
... that's probably a good cause to secretly not highlight it. Alternatively, to use alternate highlighting. Whatever most makes sense, I guess.
When the banner highlights an auto-accepting correction, it shows it with grey background and white text. It also shows the same styling when the current word is recognized as a word and will be selected unchanged. This is a little misleading, because it suggests that the word will be changed. It might be better to either not highlight where there are no changes, or highlight differently.
Secondary issue, the white-on-grey color contrast level is probably not an accessible combination.