keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
387 stars 107 forks source link

bug(mac): drag and drop of .kmp to configuration window installs silently #12338

Open sgschantz opened 2 weeks ago

sgschantz commented 2 weeks ago

Describe the bug

When dragging and dropping a .kmp file into the Keyman Configuration window it installs silently.

Expected behavior

After dropping a .kmp file on the Keyman Configuration window, Keyman should present a dialog to confirm that the user wants to install the keyboard. If the user agrees and the keyboard is installed successfully, then Keyman should display the Package Information window to provide details about the keyboard that was just installed.

Keyman apps

mcdurdin commented 2 weeks ago

On Windows, the standard behaviour is to show the package information dialog (metadata+readme) prior to install, then Welcome dialog after install.

sgschantz commented 2 weeks ago

@mcdurdin I was expecting the behavior to be consistent with what happens when a keyboard is installed using the Download Keyboard button in the Configuration window and plan on making it conform to that. Does that sound reasonable?

mcdurdin commented 2 weeks ago

Yeah, just noting that the behaviour between the two platforms is not the same. In terms of flow, it made sense to show the readme and metadata to the user before installation, as that helps them have the information they need to decide whether to go ahead with installation -- and then the welcome.htm is shown after installation to help the user start to use the keyboard.

So it may be more of a systemic thing to consider changing on macOS?