keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
403 stars 112 forks source link

bug(windows): When installed a kmp a link to a pdf in the readme.htm file does not display the .pdf. #12356

Open LornaSIL opened 2 months ago

LornaSIL commented 2 months ago

Describe the bug

When installing a .kmp, if the readme.htm has a link to a pdf in the package the pdf will not display. The same link works if it's in the welcome.htm.

In addition, once I install the keyboard and go to OSK, Help button, I get the welcome.htm, but when I click on the link, it does not display the .pdf.

I would expect the pdf to display each time I click on the link.

Reproduce the bug

  1. Install https://keyman.com/keyboards/gautami_thamizh_tamil
  2. Click on readme tab and then on the pdf link (it won't open)
  3. Click on Install a. Welcome.htm shows up. b. Click on pdf link - below table (pdf shows)
  4. Select keyboard
  5. Select On-Screen keyboard
  6. Click on question mark (welcome.htm displays)
  7. Click on link for pdf below table (it won't open)
  8. Go to C:\ProgramData\Keyman\Keyman Engine\Keyboard_Package\gautami_thamizh_tamil a. Open welcome.htm b. Click on link to pdf and it opens

Expected behavior

pdf should always show when you click on the link.

Related issues

No response

Keyman apps

Keyman version

17.0.326

Operating system

Windows 11

Device

No response

Target application

No response

Browser

No response

Keyboard name

gautami_thamizh_tamil

Keyboard version

1.0

Language name

Tamil

Additional context

gautami_tamil

rc-swag commented 2 months ago

I can reproduce Step 2. - it is trying to show the pdf via localhost.

However, Step 7 works for me. It opens the file directly on the installed file system.

rc-swag commented 2 weeks ago

@LornaSIL I tested this on version 18.0.107-alpha and it now all works for me. I don't know what has changed though. Can you please test to see if it still doesn't work for you?

LornaSIL commented 2 weeks ago

@LornaSIL I tested this on version 18.0.107-alpha and it now all works for me. I don't know what has changed though. Can you please test to see if it still doesn't work for you?

Are you testing the online keyboard? He's changed the link to reference the online pdf! I'll see about testing with another keyboard if I can find one.

LornaSIL commented 2 weeks ago

Try this keyboard: https://keyman.com/keyboards/bu_phonetic It has a link to a local pdf in both the readme.htm and welcome.htm. I'm having similar issues to the previous ones on Keyman 17.0