bug(core): crasher when transform substituting a uset on the RHS

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web

https://keyman.com/

Other

399 stars 112 forks source link

bug(core): crasher when transform substituting a uset on the RHS #12455

Closed srl295 closed 6 days ago

srl295 commented 1 month ago

Repro: type w

<variables>
    <uset id="triisap"      value="[\u{17CA}]" />
</variables>
    <transforms type="simple">
        <transformGroup>
              <transform from="w" to="$[triisap]" />
        </transformGroup>
    </transforms>

srl295 commented 1 month ago

should error on compile

srl295 commented 1 month ago

i need to look closer at the failure mode, may be able to avoid it
do we want to report this via sentry rather than just an assert?
also- on the compiler, we should be able to attempt the substitution as part of the compiler to see if the replacement string is valid or not

mcdurdin commented 6 days ago

So ... my only question here is: could malformed .kmx still crash Core?

mcdurdin commented 5 days ago

And in answer to my question -- this is not a crash in core, but an assertion. We should not have assertions enabled in a release build -- so we need to check that.