search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
403 stars 112 forks source link

fix(mac): make modifiers operational in OSK #12556

Closed sgschantz closed 1 month ago

sgschantz commented 1 month ago

With different layers active in the OSK, clicking on a key should produce the character represented on the key to be output.

Fixes #6578

User Testing

SUITE_OSK_MODIFIERS: test varying outputs for different modifiers

  1. Install this version of Keyman and switch to the Khmer Angkor keyboard
  2. Open the OSK
  3. Click on the 'S' key
  4. Confirm that this generates the character ស
  1. Open the OSK
  2. Make sure that the text insertion point is immediately to the right of the previously typed ស
  3. Click on the Shift key in the OSK (designated with the up arrow) so that the Shift layer is displayed
  4. Click on the 'S' key
  5. Confirm that the previously generated character 'ស' now has a vowel inserted to the left, resulting in សៃ
  1. Install this version of Keyman and switch to the Khmer Angkor keyboard
  2. Open the OSK
  3. Click on the Alt key in the OSK so that the Alt layer is displayed
  4. Click on the 'S' key
  5. Confirm that this generates the character -
  1. Install this version of Keyman and switch to the Khmer Angkor keyboard
  2. Open the OSK
  3. Click on the Alt key in the OSK so that the Alt layer is displayed
  4. Additionally click on the Shift key in the OSK so that the Alt-Shift layer is displayed
  5. Click on the 'S' key
  6. Confirm that this generates the character ᧭
keymanapp-test-bot[bot] commented 1 month ago

User Test Results

Test specification and instructions

✅ SUITE_OSK_MODIFIERS: test varying outputs for different modifiers

8 tests in 2 groups PASSED * ✅ GROUP_VENTURA: test with macOS Ventura
4 tests PASSED - ✅ **TEST_OSK_BASE_LAYER ([PASSED](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))** ([notes](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459)) - ✅ **TEST_OSK_SHIFT_LAYER ([PASSED](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))** ([notes](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459)) - ✅ **TEST_OSK_ALT_LAYER ([PASSED](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))** ([notes](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459)) - ✅ **TEST_OSK_ALT_SHIFT_LAYER ([PASSED](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))** ([notes](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))
* ✅ GROUP_SONOMA: test with macOS Sonoma
4 tests PASSED - ✅ **TEST_OSK_BASE_LAYER ([PASSED](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))** ([notes](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459)) - ✅ **TEST_OSK_SHIFT_LAYER ([PASSED](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))** ([notes](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459)) - ✅ **TEST_OSK_ALT_LAYER ([PASSED](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))** ([notes](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459)) - ✅ **TEST_OSK_ALT_SHIFT_LAYER ([PASSED](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))** ([notes](https://github.com/keymanapp/keyman/pull/12556#issuecomment-2419921459))

Test Artifacts

dinakaranr commented 1 month ago

Test Results

I tested this issue with the attached "Keyman 18.0.126-alpha-local" build on the macOS Sonoma 14.5 and Big Sur 11.0.1. I am sharing my observation.

SUITE_OSK_MODIFIERS: test varying outputs for different modifiers

GROUP_VENTURA: test with macOS Ventura

Installed "Keyman 18.0.126-alpha-local" build on the macOS Big Sur 11.0.1. I had confirmation from the developer to test this PR in the Big Sur because I did not have the macOS Ventura. Installed the Khmer Angkor keyboard

GROUP_SONOMA: test with macOS Sonoma

Installed "Keyman 18.0.126-alpha-local" build on the macOS Sonoma 14.5. Installed the Khmer Angkor keyboard.

mcdurdin commented 1 month ago

One more, holding Option+Shift on the hardware keyboard shows either Alt or Shift layer, not Alt+Shift layer (e.g. test on Khmer Angkor). It seems to work correctly when clicking the keys on the OSK

sgschantz commented 1 month ago

Code changes look good.

I had a test of the OSK on my mac, and a few things I think should happen (some of which may be addressed in #12565?):

  1. Pressing any modifier key on the hardware keyboard should reset all the OSK-selected modifier keys. This is the behaviour we settled on in Keyman for Windows, and it seems to be the most reliable option. (Testing right now, I am not sure if that is happening on Windows?)
  2. Closing the OSK should reset the modifier state to default
  3. The modifier state on the OSK should affect the hardware keys typed. Right now they seem completely independent.

I think we should document these and your other suggestion either in an issue or, probably better, as part of a Monday design meeting -- especially if it should be consistent across platforms. I didn't really try to design for these scenarios as I was just focusing on the one issue, and the correct interaction between the OSK and the physical keyboard is not intuitive to me. If we discuss in a group, we may come with some other edge cases that you haven't covered yet.

sgschantz commented 1 month ago

LGTM

OK, let's follow up on the other issues separately. Will you track them?

created #12582 and #12584 to track these

keyman-server commented 1 month ago

Changes in this pull request will be available for download in Keyman version 18.0.131-alpha