keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
403 stars 112 forks source link

chore(developer): skip masaram_gondi in kmcmplib full test #12630

Closed mcdurdin closed 2 weeks ago

mcdurdin commented 2 weeks ago

masaram_gondi.kmx fixture is built from a known-bad source, which is caught in kmcmplib 18.0.

This failure is because the keyboard source had non-BMP characters in the key part of the rule on line 215, which has been picked up by the 18.0 compiler in #11806:

$keymanonly: if(opt1 = 'gondi') any(Vyanjana)"𑵄" + any(Vyanjana)    >   index(Vyanjana,2) U+11D45

The trick here is that the compiled fixture developer/src/kmcmplib/tests/fixtures/keyboards-repo/masaram_gondi.kmx is based on a broken version of the keyboard source in the keyboards repo (fixed version), and updating to the fixed version will also trigger updates to a bunch of other keyboards. I think the simplest resolution is probably to skip masaram_gondi for 18.0.

Relates-to: #12623 Relates-to: #11806

@keymanapp-test-bot skip

keymanapp-test-bot[bot] commented 2 weeks ago

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

keyman-server commented 2 weeks ago

Changes in this pull request will be available for download in Keyman version 18.0.137-alpha