keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
402 stars 112 forks source link

fix(windows): help links updated #12646

Closed rc-swag closed 1 week ago

rc-swag commented 2 weeks ago

Fixes:#12463

The help link passed to the opening of the keyman help(CHM) on windows was broken for a number of the help links. This updates them. Note: no help exists for apEntryHelper so it was set to the main index instead

keymanapp-test-bot[bot] commented 2 weeks ago

User Test Results

Test specification and instructions

Test Artifacts

mcdurdin commented 2 weeks ago

Note: no help exists for apEntryHelper so it was set to the main index instead

Was reserved for a feature that has never been implemented (requested recently again in #12562)

rc-swag commented 2 weeks ago

User Testing

(taken from the original issue steps to reproduce) Install Keyman from the PR build TEST_ONSCREEN_KBD_1

  1. Open the Keyman configuration app.
  2. Navigate to the "Keyboard Layouts" tab.
  3. Install one or two keyboards (e.g. Khmer Angkor, Imperial Aramaic)
  4. Navigate to the systems page. Click the "Install Keyboard or Dictionary"
  5. Open the OSK and then select the keyboard.
  6. Click the help icon on the OSK window.
  7. The "Keyman Help" dialog appears and click the "Help Contents" link button.
  8. Expected Results: The Keyman for Windows User guide help appears here, and text on the right is Keyman Toolbox - On Screen Keyboard

TEST_FONT_HELPER

  1. Open the OSK and then select the keyboard.
  2. Click the font helper icon on the tool bar (has a "T" on it)
  3. Click the help icon on the OSK window.
  4. The "Keyman Help" dialog appears and click the "Help Contents" link button.
  5. Expected Results: The Keyman for Windows User guide help appears here, and text on the right is Keyman Toolbox - Font Helper

TEST_CHARACTER_MAP

  1. Open the OSK and then select the keyboard.
  2. Click the character map icon on the tool bar (has a grid with letters)
  3. Click the help icon on the OSK window.
  4. The "Keyman Help" dialog appears and click the "Help Contents" link button.
  5. Expected Results: The Keyman for Windows User guide help appears here, and text on the right is Keyman Toolbox - Character Map
rc-swag commented 2 weeks ago

Was reserved for a feature that has never been implemented (requested recently again in #12562)

Thank you for the info. Otherwise I was going to raise an issue to remove it.

dinakaranr commented 2 weeks ago

Test Results

I tested this issue with the attached "18.0.137-alpha-test-12646" build on the Windows 10 and 11 OS. Here is my observation.

Verified that the "Keyman for Windows User Guide" help appeared. Focus appeared on the Keyman Toolbox—On-Screen Keyboard and help content displayed. It works well.

Verified that the "Keyman for Windows User Guide" help appeared. Focus did not appear on the Keyman Toolbox—Font Helper and Help content displayed for OSK. It seems to not be correct. The focus needs to be on an appropriate topic. 

Verified that the "Keyman for Windows User Guide" help appeared. Focus did not appear on the Keyman Toolbox—Character Map and Help content displayed for OSK. It seems to not be correct. The focus needs to be on an appropriate topic.  I am seeing this behavior on window 10 and window 11 OS

rc-swag commented 1 week ago

Thank you @dinakaranr I have fixed this once the build is complete please retest @keymanapp-test-bot retest TEST_FONT_HELPER TEST_CHARACTER_MAP

dinakaranr commented 1 week ago

Test Results

I tested this issue with the attached "18.0.137-alpha-test-12646" build on the Windows 10 OS. I'm sharing my observation here.

keyman-server commented 1 week ago

Changes in this pull request will be available for download in Keyman version 18.0.139-alpha