keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web

https://keyman.com/

Other

402 stars 112 forks source link

fix(core): permanently disable logging 🏠 #12674

Open ermshiperete opened 1 week ago

ermshiperete commented 1 week ago

This change disables logging at compile time to work around #12661. Logging can be enabled in the debugger, or by re-compiling with g_debug_KeymanLog set to TRUE.

Related: #12661

User Testing

TEST_NOLOG: Run this test on Linux to verify that logging is disabled

open a terminal window and show the syslog: tail -f /var/log/syslog
switch to a Keyman keyboard and type a few characters in any application, e.g. Writer
verify that a keypress doesn't output lines containing ibus-engine-keyman in the syslog

keymanapp-test-bot[bot] commented 1 week ago

User Test Results

Test specification and instructions

✅ TEST_NOLOG (PASSED) (notes)

Test Artifacts

mcdurdin commented 1 week ago

@rc-swag does this impact Windows? @sgschantz does this impact macOS?

Obviously we need a separate interface for debug for Core.

dinakaranr commented 6 days ago

Test Results

I tested this issue with the attached Keyman "17.0.333" (package version 17.0.333-1~PR-12674-4017.1+jammy1) build on the Noble & Jammy. Here is my observation.

TEST_NOLOG (Passed):
1. Installed the "17.0.333-1~PR-12674-4017.1+jammy1" file.
2. Open the terminal window and then run the "tail -f /var/log/syslog" command.
3. Installed the "Khmer Angkor" keyboard on the "Keyman Configuration" dialog.
4. Open the text editor application.
5. Change the keyboard from English to Khmer keyboard.
6. Enter the text in the text editor application.
7. Verified that the "ibus-engine-keyman" log message did not appear in the syslog. (When switching the keyboard or when typing a text.) Please take a look at the screenshot. It works well. Thank you.