keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
382 stars 107 forks source link

feat(android,ios): Firstvoices: Use the metadata in kmp.json to associate with languages and versions #2036

Open mcdurdin opened 4 years ago

mcdurdin commented 4 years ago

Is your feature request related to a problem? Please describe.

FirstVoices Keyboards currently does not make use of the BCP 47 language tags in the kmp data included with keyboards. In the future, we'd like to make this possible, and reduce the amount of data required in the source keyboards.csv file for correct deployment of the app.

darcywong00 commented 5 months ago

Since we haven't been updating the keyboard versions listed in keyboards.csv, it leads to confusion with users on whether the latest keyboards updates are installed.

Things to consider:

darcywong00 commented 2 months ago

From A18S2 sprint planning meeting, @mcdurdin clarified (since we can't add regions to kmp.json): Keep only the minimal fields in keyboards.csv

Keyboard version info should use kmp.json.

mcdurdin commented 2 months ago
  • Primary language and language name

This should be sourced from kmp.json where possible? AFAIK, most of the keyboards have only one language entry; the language name should always be there too.

darcywong00 commented 2 months ago

This should be sourced from kmp.json where possible? AFAIK, most of the keyboards have only one language entry; the language name should always be there too.

Yeah, though there's also basic_kbdcan and sil_euro_latin...

mcdurdin commented 2 months ago

Yeah, though there's also basic_kbdcan and sil_euro_latin...

So those are two examples where we need the extra metadata of default language. There may be others too, but not too many hopefully.

darcywong00 commented 2 months ago

ok, turns out basic_kbdcan has a first language of fr-CA. So maybe just sil_euro_latin needing to define default en. Do we want that in the keyboards.csv file or in the FV app code?

mcdurdin commented 2 months ago

Do we want that in the keyboards.csv file or in the FV app code?

Per discussion on Slack, I think we put that in the FV app code. (Let's also put in a hard-coded value for basic_kbdcan, so that we don't accidentally end up with it swapping in the future.)