search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
398 stars 112 forks source link

[Android] Lexical models fail to install because lexical model version no longer generated #2190

Closed darcywong00 closed 5 years ago

darcywong00 commented 5 years ago

Describe the bug User reported issue from community site

Lexical models built with Keyman Developer 12.0.50 stable no longer include lexical model versions (they use the lexical model package version).

However, the Android and iOS apps were developed to expect a lexical model version, so this is causing the new model packages to fail at installation.

(The published models on downloads.keyman.com/models haven't been updated with the new lexical model compiler so they currently contain model version info)

Install a Mozhi Malayalam keyboard for testing.

Testing with a model package built from https://my.pcloud.com/publink/show?code=kZlX3LkZpVxg32Gpk4BRIGIW5M7hhBSpWXik

Fix

The fix is to use the package version "info/version/description" for the lexical model version. If package version doesn't exist, fall back to "1.0"

Configuration

Keyman Developer 12.0.50 Stable Keyman Android 12.0.4201 Stable

darcywong00 commented 5 years ago

Fixed in Keyman for Android 12.0.4042

darcywong00 commented 5 years ago

Issue re-opened because the lexical model version impacts the ModelPickerActivity