keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
398 stars 112 forks source link

[Developer] Keyboard_info merge incorrectly assumes sil_myanmar_mywinext has mobile keyboards #2199

Closed mcdurdin closed 4 years ago

mcdurdin commented 5 years ago

Describe the bug

While https://github.com/keymanapp/keyboards/tree/master/release/sil/sil_myanmar_mywinext targets desktop + web, it does not currently target mobile devices. However, the .keyboard_info merge generates the following platformSupport object:

  "platformSupport": {
    "windows": "full",
    "macos": "full",
    "linux": "full",
    "desktopWeb": "full",
    "mobileWeb": "full",
    "android": "full",
    "ios": "full"
  }

To reproduce ./build.sh release/sil/sil_myanmar_mywinext in the keyboards repo root. The resulting release/sil/sil_myanmar_mywinext/build/sil_myanmar_mywinext.keyboard_info has the incorrect platformSupport.

Expected behavior The entries for mobileWeb, android, and ios should either be none or not present.


Keyman Developer:

(That version should be updated to 12.0 now as well...)

mcdurdin commented 5 years ago

Depends on https://github.com/keymanapp/keyboards/issues/337; see comment in MergeKeyboardInfo.pas, around line 1064:

    // TODO: Don't add Android and iOS when we complete the addition of all .js keyboards
    // to packages in the repository (including legacy keyboards)