[Developer] kmlmi crashes when Author email missing in .kps file

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web

https://keyman.com/

Other

398 stars 112 forks source link

Closed eddieantonio closed 4 years ago

eddieantonio commented 4 years ago

This prevented the build in keymanapp/lexical-models#60.

I think kmlmi just ignored an undefined check -- easy workaround.

darcywong00 commented 4 years ago

Maybe a duplicate of #2370

eddieantonio commented 4 years ago

It's more of an extension of #2370. Both can be fixed in one PR. @mcdurdin Should a missing author email emit a warning, or is it no big deal?

mcdurdin commented 4 years ago

Missing author email is not a problem. Packages without an email address are perfectly valid.