keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
398 stars 112 forks source link

[Developer] Lower-case Lexical model projects paths when creating from template #2513

Closed darcywong00 closed 4 years ago

darcywong00 commented 4 years ago

Describe the bug A lexical model was generated by Keyman Developer 12 project template. See keymanapp/lexical-models#64. The BCP 47 tag bcc-Arab resulted in the project being created in a directory /release/sil/sil.bcc-Arab.upp_ptw11.

To avoid file-casing conflicts, the created folders should be lower-cased. (e.g. sil.bcc-arab.upp_ptw11)

Configuration:

Keyman Developer 12.0.64.0 Windows 10

mcdurdin commented 4 years ago

I'm unable to reproduce this issue -- the code already lower-cases the model id and in testing I can't make it go wrong. The fix was made in #2050 which landed in Windows beta 12.0.26.

mcdurdin commented 4 years ago

Please re-open if you find a repro.