search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
399 stars 112 forks source link

feat(developer): Support full tablet keyboard + reduced phone keyboard template in touch layout editor #2656

Open mcdurdin opened 4 years ago

mcdurdin commented 4 years ago

Per Ron Lockwood (via email):

One thing I’ve found annoying in the touch keyboard layout of Keyman developer, is that I can’t easily get a full tablet keyboard and a reduced phone keyboard. Unless I’m missing something.

I do an import from On Screen, that gives me all the letters. Now I would like to have a phone layout that has a much reduce number of keys. I add the Phone platform. I use template and select the Basic template. Great. But when I got back to my tablet it now has the reduced set of keys.

I would like the template to just apply to the platform I’m working on.

The workaround I’ve done is to copy the code for the tablet before I apply a template and then paste it back in. But this is tedious.

Follow up:

Maybe I’ve figured something out. It seems that if I pick Traditional template, I get a normal tablet layout and a phone layout with reduced number of keys. The other templates seem to change both to reduced number. Of course I’m not quite sure because I’m getting a crash when I do this every time. You should have gotten the crash report (MD: found the crash report at https://github.com/sillsdev/keyman-issues/issues/6231).

MattGyverLee commented 3 years ago

Yes, I realized while researching https://github.com/keymanapp/keyman/issues/4153 that the Phone/Tablet flag works for iPhone/iPad, but not for Android Phone/Tablet. Devices like the Nexus 7, available as an option in Google Chrome debugging, should be recognized as a tablet, but it is not. I'm not sure if this currently works on "real" devices.

What are the cutoffs for distinguishing a phone, tablet, and phablet?

You should be able to test your tablet keyboard on the iPad emulation, but currently (KeyDev 14), you can only test the tablet layout on Android by tweaking the source code at runtime:

image

The formatting on Android tablets will still be old-school until my pull request (https://github.com/keymanapp/keyman/pull/4154) is approved.

This has implications in styling, as well as key number an placement as mentioned above.

mcdurdin commented 3 years ago

@MattGyverLee note that that is not related to this issue, which is around the templates available for producing phone and tablet layouts within Keyman Developer itself.

MattGyverLee commented 3 years ago

"But when I got back to my tablet it now has the reduced set of keys."

Fair enough, I guess I read this part wrong. I can delete my comments here if you prefer.

mcdurdin commented 3 years ago

I can delete my comments here if you prefer.

It's not a big deal, we've got the comment history to clarify any confusion 😉