keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
394 stars 110 forks source link

bug(developer): Redist path not specified #5212

Closed MakaraSok closed 3 years ago

MakaraSok commented 3 years ago

Describe the bug

When "Compile Installer", an error occurs even though .kmp is compiled successfully.

khmer_angkor.kps: Compiling package khmer_angkor.kps...
khmer_angkor.kps: Redist path not specified, loading default (C:\Program Files (x86)\Keyman\Keyman Developer\redist\setup\)
khmer_angkor.kps: Compiling package khmer_angkor.kps...
khmer_angkor.kps: Success: 'C:\keyman\keyboards\keyboards\release\k\khmer_angkor\source\khmer_angkor.kps' compiled successfully.

When going to the build folder, the .exe is found and that's the expected bundle. image

To Reproduce

  1. Go to 'khmer_angkor' keyboard folder
  2. Click to open '.kpj' and configure the "Compile Installer"
  3. Compile Installer
  4. See error

Expected behavior

Since the setup.exe is in C:\Program Files (x86)\Keyman\Keyman Developer\Redist\Setup, the compile should not say the path doesn't exist.


Keyman Developer:


Keyboard

Additional context

cf: https://github.com/keymanapp/keyman/issues/4354

mcdurdin commented 3 years ago

Yeah, that's not an error, just information -- so I think we can leave it as is.

MakaraSok commented 3 years ago

Yeah, that's not an error, just information -- so I think we can leave it as is.

Why was the info given? Why the path was not specified? Should the path be specified manually? If so, how?

mcdurdin commented 3 years ago

This is all very old UX -- it hasn't been updated for possibly 10 years. So ...

Why was the info given?

Just telling the keyboard dev that the default redistributable is in use.

Should the path be specified manually?

Not normally, no.

If so, how?

I think it can be set in the last page of the Package Editor.