keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
372 stars 102 forks source link

fix(linux): Fix reordering of output #7079

Closed ermshiperete closed 1 year ago

ermshiperete commented 1 year ago

Quick link to the test results

This change implements a commit queue which allows to control the order of the output. This ensures that any backspace we generate will be processed before the character we're adding.

Requires changes in ibus (surrounding text fix (see #7072) and prefilter change).

User Testing

Preparations

SUITE_WRITER: LibreOffice Writer

Open LibreOffice Writer.

Tests

SUITE_GEDIT: gedit

Open gedit.

Tests

SUITE_FIREFOX: Firefox

Open https://keyman.com/keyboards in Firefox.

NOTE: If the output looks wrong, copy the text from the browser and paste it into gedit and verify that it there.

Tests

SUITE_CHROMIUM: Chromium

Open Chromium browser.

NOTE: If the output looks wrong, copy the text from the browser and paste it into gedit and verify that it there.

Tests

SUITE_TERMINAL: gnome-terminal

Open Terminal.

Tests

SUITE_ANKI: Anki

Open Anki.

Tests

SUITE_SEARCHBAR: Searchbar in gnome-shell

Press Windows key to open searchbar.

Tests

keymanapp-test-bot[bot] commented 1 year ago

User Test Results

Test specification and instructions

✅ SUITE_WRITER: LibreOffice Writer

20 tests in 4 groups PASSED * ✅ GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_WRITER_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))**: Tested this as per the instructions in LibreOffice Writer 7.3 and it is working as expected. - ✅ **TEST_WRITER_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))**: Tested this as per the instructions in LibreOffice Writer 7.3 and it is working as expected. - ✅ **TEST_WRITER_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1246653104))**: Installed 'Siddhanta' font in LibreOfficer Writer 7.3 and now I am able to see the expected output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1246653104)) - ✅ **TEST_WRITER_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269574977))**: Retested this as per Eberhard's instructions and after changing the font, I was able to see the expected output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269574977)) - ✅ **TEST_WRITER_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))**: Tested this as per the instructions in LibreOffice Writer 7.3 and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))
* ✅ GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_WRITER_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in LibreOffice Writer 6.4.7.2 and it is working as expected. - ✅ **TEST_WRITER_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in LibreOffice Writer 6.4.7.2 and it is working as expected. - ✅ **TEST_WRITER_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in LibreOffice Writer 6.4.7.2 and it is working as expected. - ✅ **TEST_WRITER_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in LibreOffice Writer 6.4.7.2 and it is working as expected. - ✅ **TEST_WRITER_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in LibreOffice Writer 6.4.7.2 and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))
* ✅ GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_WRITER_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1241998319))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions in Jammy_X11 and I was able to see the expected output. - ✅ **TEST_WRITER_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1241998319))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions and I was able to see the expected output. - ✅ **TEST_WRITER_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1241998319))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions and I was able to see the expected output. - ✅ **TEST_WRITER_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1241998319))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions and I was able to see the expected output. - ✅ **TEST_WRITER_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1241998319))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions and I was able to see the expected output. ie., Pressing the Backspace key would entirely deleted all the characters. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1241998319))
* ✅ GROUP_WASTA: Wasta 20.04 with Cinnamon
5 tests PASSED - ✅ **TEST_WRITER_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))**: Tested this as per the instructions in LibreOffice Writer 7.3.6.2 and it is working as expected. - ✅ **TEST_WRITER_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))**: Tested this as per the instructions in LibreOffice Writer 7.3.6.2 and it is working as expected. - ✅ **TEST_WRITER_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1246773462))**: After installing Siddhanta font, I am not able reproduce the font issue. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1246773462)) - ✅ **TEST_WRITER_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))**: Tested this as per the instructions in LibreOffice Writer 7.3.6.2 and it is working as expected. - ✅ **TEST_WRITER_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))**: Tested this as per the instructions in LibreOffice Writer 7.3.6.2 and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))

✅ SUITE_GEDIT: gedit

20 tests in 4 groups PASSED * ✅ GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_GEDIT_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))**: Tested this as per the instructions in Text Editor and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243549761))
* ✅ GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_GEDIT_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))**: Tested this as per the instructions in Text Editor and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243603802))
* ✅ GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_GEDIT_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1242058722))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions in Jammy_X11 and I was able to see the expected output. - ✅ **TEST_GEDIT_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1242058722))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions and I was able to see the expected output. - ✅ **TEST_GEDIT_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1242058722))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions and I was able to see the expected output. - ✅ **TEST_GEDIT_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1242058722))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions and I was able to see the expected output. - ✅ **TEST_GEDIT_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1242058722))**: Tested with the attached PR build (Keyman 16.0.59-alpha) as per the instructions and I was able to see the expected output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1242058722))
* ✅ GROUP_WASTA: Wasta 20.04 with Cinnamon
5 tests PASSED - ✅ **TEST_GEDIT_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1246790086))**: Edited the font in Preferences / Font & Colors tab in Text Editor and now I am able to see the expected output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1246790086)) - ✅ **TEST_GEDIT_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))**: Tested this as per the instructions in Text Editor and it is working as expected. - ✅ **TEST_GEDIT_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))**: Tested this as per the instructions in Text Editor and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243669040))

✅ SUITE_FIREFOX: Firefox

20 tests in 4 groups PASSED * ✅ GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_FIREFOX_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243774192))**: Tested this in the Keyboard Search filed and it is working as expected. - ✅ **TEST_FIREFOX_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243774192))**: Tested this in the Keyboard Search filed and it is working as expected. - ✅ **TEST_FIREFOX_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243774192))**: Tested this in the Keyboard Search filed and it is working as expected. - ✅ **TEST_FIREFOX_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243774192))**: Tested this in the Keyboard Search filed and it is working as expected. - ✅ **TEST_FIREFOX_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243774192))**: Tested this in the Keyboard Search filed and it is working as expected.
* ✅ GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_FIREFOX_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1268473483))**: Retested this as per eberhard's new instructions and here is my observations. Tested IP (SIL) keyboard in Keyboard Search field and it shows the expected output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1268473483)) - ✅ **TEST_FIREFOX_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1268473483))**: Tested 'Korean KORDA Jamo (SIL)' keyboard and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1268473483)) - ✅ **TEST_FIREFOX_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1268473483))**: Tested 'Vedic Sanskrit Devanagari Phonetic (ITRANS)' keyboard and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1268473483)) - ✅ **TEST_FIREFOX_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1268473483))**: Tested 'Khmer Angkor' keyboard and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1268473483)) - ✅ **TEST_FIREFOX_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1268473483))**: After Pressing Backspace key 5 times, the entire word is deleted.
* ✅ GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_FIREFOX_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274591166))**: Retested this as per the instructions in Ubuntu 22.04 Jammy X11 and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274591166)) - ✅ **TEST_FIREFOX_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274591166))**: Retested this as per the instructions in Ubuntu 22.04 Jammy X11 and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274591166)) - ✅ **TEST_FIREFOX_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274591166))**: Retested this as per the instructions in Ubuntu 22.04 Jammy X11 and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274591166)) - ✅ **TEST_FIREFOX_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274591166))**: Retested this as per the instructions in Ubuntu 22.04 Jammy X11 and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274591166)) - ✅ **TEST_FIREFOX_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274591166))**: Retested this as per the instructions in Ubuntu 22.04 Jammy X11, after Pressing Backspace key 5 times, the entire word is deleted.
* ✅ GROUP_WASTA: Wasta 20.04 with Cinnamon
5 tests PASSED - ✅ **TEST_FIREFOX_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269791338))**: Retested this with Keyman 16.0.74-alpha build as per Ebherhard's suggestion and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269791338)) - ✅ **TEST_FIREFOX_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269791338))**: Retested this and I noticed that after pasting it on the gedit, it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269791338)) - ✅ **TEST_FIREFOX_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269791338))**: Retested this and I noticed that after pasting it on the gedit, it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269791338)) - ✅ **TEST_FIREFOX_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269791338))**: Retested this in the Keyman Search bar and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269791338)) - ✅ **TEST_FIREFOX_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269791338))**: After Pressing Backspace key 5 times, the entire word is deleted.

✅ SUITE_CHROMIUM: Chromium

20 tests in 4 groups PASSED * ✅ GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_CHROMIUM_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243781540))**: Tested this in Chromium browser in Keyboard Search field and it is working as expected. - ✅ **TEST_CHROMIUM_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243781540))**: Tested this in Chromium browser in Keyboard Search field and it is working as expected. - ✅ **TEST_CHROMIUM_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269556513))**: Retested this as per Eberhard's suggestion and here is my observation. After pasting the Hindi font into gedit, the font changes and showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1269556513)) - ✅ **TEST_CHROMIUM_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243781540))**: Tested this in Chromium browser in Keyboard Search field and it is working as expected. - ✅ **TEST_CHROMIUM_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1243781540))**: Tested this in Chromium browser in Keyboard Search field and it is working as expected.
* ✅ GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_CHROMIUM_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1254793457))**: Retested this as per Eberhard's instructions (ie., following the steps as it mentioned in the Ubuntu 22.04 Jammy Linux)and it showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1254793457)) - ✅ **TEST_CHROMIUM_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274836225))**: Retested this with Keyman 16.0.76-alpha in Ubuntu Focal Linux and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274836225)) - ✅ **TEST_CHROMIUM_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274836225))**: Retested this with Keyman 16.0.76-alpha in Ubuntu Focal Linux and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274836225)) - ✅ **TEST_CHROMIUM_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1254793457))**: Retested this as per the instructions and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1254793457)) - ✅ **TEST_CHROMIUM_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1254793457))**: Retested this as per the instructions and after pressing the Backspace key 5 times all the characters have been removed.
* ✅ GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_CHROMIUM_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274637274))**: Retested this as per the instructions in (Keyman 16.0.76-alpha) Ubuntu 22.04 Jammy X11 and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274637274)) - ✅ **TEST_CHROMIUM_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274637274))**: Retested this as per the instructions in Ubuntu 22.04 Jammy X11 and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274637274)) - ✅ **TEST_CHROMIUM_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274637274))**: Retested this as per the instructions in Ubuntu 22.04 Jammy X11 and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274637274)) - ✅ **TEST_CHROMIUM_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274637274))**: Retested this as per the instructions in Ubuntu 22.04 Jammy X11 and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274637274)) - ✅ **TEST_CHROMIUM_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274637274))**: Retested this as per the instructions in Ubuntu 22.04 Jammy X11, after Pressing Backspace key 5 times, the entire word is deleted.
* ✅ GROUP_WASTA: Wasta 20.04 with Cinnamon
5 tests PASSED - ✅ **TEST_CHROMIUM_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274721244))**: Retested this as per the instructions in (Keyman 16.0.76-alpha) Wasta 20.04 Linux and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274721244)) - ✅ **TEST_CHROMIUM_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274721244))**: Retested this in Wasta Linux and it seems that after pasting the fonts in the text editor it shows the correct the output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274721244)) - ✅ **TEST_CHROMIUM_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274721244))**: Retested this in Wasta Linux and it seems that after pasting the fonts in the text editor it shows the correct the output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274721244)) - ✅ **TEST_CHROMIUM_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274721244))**: Retested this in Wasta Linux and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274721244)) - ✅ **TEST_CHROMIUM_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274721244))**: After Pressing Backspace key 5 times, the entire word is deleted.

🟩 SUITE_TERMINAL: gnome-terminal

✅ SUITE_ANKI: Anki

20 tests in 4 groups PASSED * ✅ GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_ANKI_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1249117375))**: Tested this in Anki 2.1.49 (as per Eberhard's suggestion) and it is showing the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1249117375)) - ✅ **TEST_ANKI_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1249117375))**: Tested this as per the instructions and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1249117375)) - ✅ **TEST_ANKI_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1249117375))**: Tested this as per the instructions and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1249117375)) - ✅ **TEST_ANKI_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1249117375))**: Tested this as per the instructions and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1249117375)) - ✅ **TEST_ANKI_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1249117375))**: After pressing the Backspace key 5 times all the characters have been removed from the Filter box.
* ✅ GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_ANKI_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1248115691))**: Tested this with Anki 2.1.54 and it is showing the correct output. - ✅ **TEST_ANKI_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1248115691))**: Tested this with Anki 2.1.54 and it is showing the correct output. - ✅ **TEST_ANKI_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1248115691))**: Tested this with Anki 2.1.54 and it is showing the correct output. - ✅ **TEST_ANKI_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1248115691))**: Tested this with Anki 2.1.54 and it is showing the correct output. - ✅ **TEST_ANKI_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1248115691))**: Tested this with Anki 2.1.54 and it is showing the correct output.
* ✅ GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11
5 tests PASSED - ✅ **TEST_ANKI_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247927647))**: Tested this in Anki and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247927647)) - ✅ **TEST_ANKI_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247927647))**: Tested this in Anki and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247927647)) - ✅ **TEST_ANKI_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247927647))**: Tested this in Anki and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247927647)) - ✅ **TEST_ANKI_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247927647))**: Tested this in Anki and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247927647)) - ✅ **TEST_ANKI_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247927647))**: Tested this in Anki and pressing Backspace key 5 times remove the entire word from the Filter box.
* ✅ GROUP_WASTA: Wasta 20.04 with Cinnamon
5 tests PASSED - ✅ **TEST_ANKI_IPA ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247843795))**: Tested this in Anki 2.1.54 and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247843795)) - ✅ **TEST_ANKI_KO ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247843795))**: Tested this in Anki 2.1.54 and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247843795)) - ✅ **TEST_ANKI_HI ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274821597))**: Retested this with Keyman 16.0.76-alpha build in Anki application and after pasting the fonts into the text edit, it shows the correct output. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1274821597)) - ✅ **TEST_ANKI_KM ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247843795))**: Tested this in Anki 2.1.54 and it is working as expected. ([notes](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247843795)) - ✅ **TEST_ANKI_KM_BS ([PASSED](https://github.com/keymanapp/keyman/pull/7079#issuecomment-1247843795))**: Tested this in Anki 2.1.54 and after pressing Backspace key 5 times the entire word has been removed from the Filter box.

🟩 SUITE_SEARCHBAR: Searchbar in gnome-shell

Test Artifacts

mcdurdin commented 1 year ago

Rough diagram of IPC


sequenceDiagram
    Note right of Client: _key_snooper_cb receives new key event
    Client-)IBusDaemon: ProcessKeyEvent
    IBusDaemon-)EngineDBus: ProcessKeyEvent
    EngineDBus-)EngineProcessor: process-key-event
    activate EngineProcessor
    EngineProcessor-)IBusDaemon: ForwardKeyEvent +PREFILTER
    deactivate EngineProcessor
    IBusDaemon-)Client: ForwardKeyEvent +PREFILTER

    Note right of Client: _key_snooper_cb receives forwarded key event.
    Note right of Client: +PREFILTER means we reprocess the key event
    Client-)IBusDaemon: ProcessKeyEvent +PREFILTER
    IBusDaemon-)EngineDBus: ProcessKeyEvent +PREFILTER
    EngineDBus-)EngineProcessor: process-key-event +PREFILTER
    activate EngineProcessor
    EngineProcessor-)IBusDaemon: bksp + text emitted
    deactivate EngineProcessor
    IBusDaemon-)Client: bksp + text emitted
bharanidharanj commented 1 year ago

SUITE_WRITER: LibreOffice Writer

GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_GEDIT: gedit

GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_WRITER: LibreOffice Writer

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

..in LibreOffice 7.3

SUITE_GEDIT: gedit

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

..in TextEditor

..ibus version

bharanidharanj commented 1 year ago

SUITE_WRITER: LibreOffice Writer

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

..LibreOffice Writer 6.4

SUITE_GEDIT: gedit

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

..in Text Editor

..ibus version

bharanidharanj commented 1 year ago

SUITE_WRITER: LibreOffice Writer

GROUP_WASTA: Wasta 20.04 with Cinnamon

..LibreOffice 7.3

SUITE_GEDIT: gedit

GROUP_WASTA: Wasta 20.04 with Cinnamon

..TextEditor

..ibus version

bharanidharanj commented 1 year ago

SUITE_FIREFOX: Firefox

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_CHROMIUM: Chromium

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_TERMINAL: gnome-terminal

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

ermshiperete commented 1 year ago

@bharanidharanj For the failed TEST_WRITER_HI tests, please change the font to "Siddhanta" and retest.

@keymanapp-test-bot retest SUITE_WRITER GROUP_BIONIC TEST_WRITER_HI GROUP_WASTA TEST_WRITER_HI

The failing test in Chromium on Bionic seems to be a font issue - when I connect to the test server on my Windows machine and test with Chromium and Firefox with both System Keyboard (and selected ITRANS), and the ITRANS web keyboard, with the web keyboard I get the wrong results in both browsers. However, in Firefox when I then switch to the System Keyboard the output suddenly displays correctly.

Similarly, in gnome-terminal on Bionic the display is wrong, but Keyman sends the correct output.

Same thing in gedit where the font is wrong (changing to "Siddhanta" font will display things correctly).

ermshiperete commented 1 year ago

SUITE_CHROMIUM GROUP_BIONIC TEST_CHROMIUM_HI skipped

SUITE_TERMINAL GROUP_BIONIC TEST_TERMINAL_KO skipped TEST_TERMINAL_HI skipped TEST_TERMINAL_KM skipped TEST_TERMINAL_KM_BS skipped

SUITE_GEDIT GROUP_WASTA TEST_GEDIT_HI skipped

mcdurdin commented 1 year ago

@ermshiperete I have updated your test bot skip instructions to match what the bot understands! :grin: Only 'retest' is supported asking the bot directly at present.

ermshiperete commented 1 year ago

@ermshiperete I have updated your test bot skip instructions to match what the bot understands! grin Only 'retest' is supported asking the bot directly at present.

Ahh, right. Forgot about that! Thanks!

bharanidharanj commented 1 year ago

SUITE_WRITER: LibreOffice Writer

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_WRITER: LibreOffice Writer

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_WRITER: LibreOffice Writer

GROUP_WASTA: Wasta 20.04 with Cinnamon

bharanidharanj commented 1 year ago

SUITE_GEDIT: gedit

GROUP_WASTA: Wasta 20.04 with Cinnamon

bharanidharanj commented 1 year ago

SUITE_SEARCHBAR: Searchbar in gnome-shell

GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_FIREFOX: Firefox

GROUP_WASTA: Wasta 20.04 with Cinnamon

bharanidharanj commented 1 year ago

SUITE_CHROMIUM: Chromium

GROUP_WASTA: Wasta 20.04 with Cinnamon

bharanidharanj commented 1 year ago

SUITE_TERMINAL: gnome-terminal

GROUP_WASTA: Wasta 20.04 with Cinnamon

bharanidharanj commented 1 year ago

SUITE_ANKI: Anki

GROUP_WASTA: Wasta 20.04 with Cinnamon

bharanidharanj commented 1 year ago

SUITE_SEARCHBAR: Searchbar in gnome-shell

GROUP_WASTA: Wasta 20.04 with Cinnamon

bharanidharanj commented 1 year ago

SUITE_ANKI: Anki

GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_TERMINAL: gnome-terminal

GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_CHROMIUM: Chromium

GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_FIREFOX: Firefox

GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_ANKI: Anki

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_TERMINAL: gnome-terminal

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_CHROMIUM: Chromium

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_FIREFOX: Firefox

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_SEARCHBAR: Searchbar in gnome-shell

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_SEARCHBAR: Searchbar in gnome-shell

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_ANKI: Anki

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_CHROMIUM: Chromium

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_TERMINAL: gnome-terminal

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

ermshiperete commented 1 year ago

I can't repro the test failure in Writer on Bionic. @bharanidharanj would you please try again? As for Chromium on Focal and Wasta, I updated the instructions: you'll have to install Chromium in the same way as on Ubuntu 22.04, sorry, I overlooked that before. And on Ubuntu 22.04 things work as expected with Chromium 101.0.4951.15.

@keymanapp-test-bot retest SUITE_WRITER GROUP_BIONIC TEST_WRITER_KM SUITE_CHROMIUM GROUP_FOCAL TEST_CHROMIUM_IPA TEST_CHROMIUM_KO TEST_CHROMIUM_HI TEST_CHROMIUM_KM TEST_CHROMIUM_KM_BS GROUP_WASTA TEST_CHROMIUM_IPA TEST_CHROMIUM_KO TEST_CHROMIUM_HI TEST_CHROMIUM_KM TEST_CHROMIUM_KM_BS GROUP_JAMMY_X11 TEST_CHROMIUM_IPA TEST_CHROMIUM_KO TEST_CHROMIUM_HI TEST_CHROMIUM_KM TEST_CHROMIUM_KM_BS

ermshiperete commented 1 year ago

The failing test in Chromium on Bionic seems to be a font issue. Ignoring that test:

SUITE_CHROMIUM GROUP_BIONIC TEST_CHROMIUM_HI skipped

Looks like the searchbar in Bionic, Focal, and Wasta doesn't have the fix that is available in Jammy. Ignoring those tests:

SUITE_SEARCHBAR GROUP_BIONIC TEST_SEARCHBAR_IPA skipped TEST_SEARCHBAR_KO skipped TEST_SEARCHBAR_HI skipped TEST_SEARCHBAR_KM skipped TEST_SEARCHBAR_KM_BS skipped

GROUP_FOCAL TEST_SEARCHBAR_IPA skipped TEST_SEARCHBAR_KO skipped TEST_SEARCHBAR_HI skipped TEST_SEARCHBAR_KM skipped TEST_SEARCHBAR_KM_BS skipped

GROUP_WASTA TEST_SEARCHBAR_IPA skipped TEST_SEARCHBAR_KO skipped TEST_SEARCHBAR_HI skipped TEST_SEARCHBAR_KM skipped TEST_SEARCHBAR_KM_BS skipped

In gnome-terminal on Bionic, Focal and Wasta the display is wrong, but Keyman sends the correct output. Ignoring those tests:

SUITE_TERMINAL GROUP_BIONIC TEST_TERMINAL_KO skipped TEST_TERMINAL_HI skipped TEST_TERMINAL_KM skipped TEST_TERMINAL_KM_BS skipped

GROUP_FOCAL TEST_TERMINAL_KO skipped TEST_TERMINAL_HI skipped TEST_TERMINAL_KM skipped TEST_TERMINAL_KM_BS skipped

GROUP_WASTA TEST_TERMINAL_KO skipped TEST_TERMINAL_HI skipped TEST_TERMINAL_KM skipped TEST_TERMINAL_KM_BS skipped

ermshiperete commented 1 year ago

Hmm, in Firefox things work in the address bar, but not on a webpage (e.g. https://keyman.com/keyboards) :confused: .

bharanidharanj commented 1 year ago

SUITE_CHROMIUM: Chromium

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_CHROMIUM: Chromium

GROUP_WASTA: Wasta 20.04 with Cinnamon

bharanidharanj commented 1 year ago

SUITE_CHROMIUM: Chromium

GROUP_JAMMY_X11: Ubuntu 22.04 Jammy with Gnome Shell and X11

bharanidharanj commented 1 year ago

SUITE_WRITER: LibreOffice Writer

GROUP_BIONIC: Ubuntu 18.04 Bionic with Gnome Shell and X11

ermshiperete commented 1 year ago

@bharanidharanj Would you please retest in Firefox with ibus version *sil2.1* (running sudo apt update && sudo apt upgrade should update to that version) and the Keyman packages from this PR? Thanks!

@keymanapp-test-bot retest SUITE_FIREFOX GROUP_FOCAL TEST_FIREFOX_IPA TEST_FIREFOX_KO TEST_FIREFOX_HI TEST_FIREFOX_KM TEST_FIREFOX_KM_BS GROUP_JAMMY_X11 TEST_FIREFOX_IPA TEST_FIREFOX_KO TEST_FIREFOX_HI TEST_FIREFOX_KM TEST_FIREFOX_KM_BS GROUP_WASTA TEST_FIREFOX_IPA TEST_FIREFOX_KO TEST_FIREFOX_HI TEST_FIREFOX_KM TEST_FIREFOX_KM_BS SUITE_WRITER GROUP_BIONIC TEST_WRITER_KM

bharanidharanj commented 1 year ago

@bharanidharanj Would you please retest in Firefox with ibus version sil2.1 (running sudo apt update && sudo apt upgrade should update to that version) and the Keyman packages from this PR? Thanks!

@keymanapp-test-bot retest SUITE_FIREFOX GROUP_FOCAL TEST_FIREFOX_IPA TEST_FIREFOX_KO TEST_FIREFOX_HI TEST_FIREFOX_KM TEST_FIREFOX_KM_BS GROUP_JAMMY_X11 TEST_FIREFOX_IPA TEST_FIREFOX_KO TEST_FIREFOX_HI TEST_FIREFOX_KM TEST_FIREFOX_KM_BS GROUP_WASTA TEST_FIREFOX_IPA TEST_FIREFOX_KO TEST_FIREFOX_HI TEST_FIREFOX_KM TEST_FIREFOX_KM_BS

@ermshiperete Sure. I will do it. Thanks.

bharanidharanj commented 1 year ago

SUITE_FIREFOX: Firefox

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

ermshiperete commented 1 year ago

Looks like the failing test in Writer in Bionic is caused by a wrong font. @bharanidharanj After typing x make sure that Khmer Mondulkiri font is shown; otherwise select the text, set Khmer Mondulkiri font and then continue typing. That way I got things to work.

ermshiperete commented 1 year ago

@keymanapp-test-bot retest SUITE_WRITER GROUP_BIONIC TEST_WRITER_KM

ermshiperete commented 1 year ago

Looks like the failing test in Chromium in Bionic is also caused by Chromium choosing the wrong font. @bharanidharanj Please copy the text displayed in Chromium and paste it into gedit and verify it there.

@keymanapp-test-bot retest SUITE_CHROMIUM GROUP_BIONIC TEST_CHROMIUM_HI