search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
398 stars 112 forks source link

chore(core): add script action for rebuilding ldml header and move ts from core to common 🙀 #7126

Open mcdurdin opened 2 years ago

mcdurdin commented 2 years ago

It is best if we don't have deep deps on core/include/ldml for ts builds. So move the relevant files into common/ somewhere. (This is a bit recursive as well at present because kmc depends on core/include/ldml, but core depends on kmc for building tests, and this change would fix that.)

The .ts file should be a part of common/web/types. The .h file should go in /common/include (and should be .gitignored). ldml-const-builder should go in /common/tools/ldml-const-builder.

i'd put a script action in here for the generation, minor though

_Originally posted by @srl295 in https://github.com/keymanapp/keyman/pull/7113#discussion_r953986031_

In core/include/ldml/package.json

mcdurdin commented 2 years ago

I'm going to bump this to 17.0 because I think I'd like to refactor slightly more -- moving at least the .ts files out of core/ and into common/, as they are shared between Core and Developer. This also removes all typescript from Core, which is neater.

General aim: I am trying to avoid cross reference of individual files across modules, so our dependency map stays clean.