keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
398 stars 112 forks source link

bug(web): Longpress on spacebar gives a very wide longpress menu which looks rather strange #7863

Open bharanidharanj opened 1 year ago

bharanidharanj commented 1 year ago

Describe the bug

While long pressing the Spacebar key in the Khmer Angkor keyboard, there is an extra (without caption) space bar appears over the actual keyboard.

Reproduce the bug

  1. Install Keyman 17.0.13 Alpha build.
  2. Open Keyman In-app.
  3. Verify EuroLatin (SIL) Keyboard appears as the default keyboard.
  4. Long press any letters in the Keyboard.
  5. Verify the long press key of any letter works.
  6. Long press Space bar key.
  7. Verify no it does not show up anything.
  8. Download and install Khmer Angkor Keyboard.
  9. Switch to Khmer Angkor Keyboard.
  10. Long press the Space bar key.

Here, I noticed that an extra spacebar key appears upon the actual spacebar key. Seems to be an issue.

..Extra space bar while long pressing the Khmer Angkor keyboard

Expected behavior

  1. While long pressing the Spacebar key, it should not show up another empty keyboard over the actual keyboard. (in Khmer Angkor Keyboard)

Related issues

No response

Keyman apps

Keyman version

17.0.13

Operating system

iOS 15.0

Device

iPhone 12 Pro Max Simulator, iPad Air (4 generation)

Target application

Keyman In-App

Browser

No response

Keyboard name

khmer_angkor

Keyboard version

1.3

Language name

Khmer

Additional context

No response

mcdurdin commented 1 year ago

This is actually by design (even if perhaps not 'great' design!) -- a longpress on the spacebar allows you to insert a real space; the default is to insert a zero-width space.

Two things I can see here:

  1. What is shown on the longpress is unintuitive (an issue with Khmer Angkor keyboard @MakaraSok?)
  2. The very-wide longpress key looks strange (a design issue for KeymanWeb)
bharanidharanj commented 1 year ago

@mcdurdin Tested the same scenario with Android emulator and I noticed that it shows an empty key while long pressing the space bar key.

..empty key appears in Android emulator

mcdurdin commented 1 year ago

It might be good to change the Khmer Angkor keyboard to show 'space' or Khmer equivalent on that key?