keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
402 stars 112 forks source link

bug(windows): Installation loop happens after clicking the OK button from the warning message during Galaxie Greek / Hebrew Keyboard installation #8368

Open bharanidharanj opened 1 year ago

bharanidharanj commented 1 year ago

Describe the bug

I noticed that while installing the Galaxie Greek / Hebrew Keyboard as the Fourth keyboard, I got a warning message 'windows has a limit of 4 custom 'transient' languages, and you may have reached this limit' in the Configuration dialog.

Reproduce the bug

Here, What I did is:

  1. Installed the latest Keyman 17.0.60-alpha build from Status Keyman site.
  2. In the Keyman Configuration dialog, using download keyboard button, I have installed Khmer Angkor, Eurolatin (SIL) and Korean KORDA Jamo (SIL) keyboards.
  3. Then, I tried to install Galaxie Greek / Hebrew (Positional) Keyboard.

I got a warning message 'Unable to install keyboard language; Windows has a limit of 4 custom 'transient' languages, and you may have reached this limit' appears with OK button.

Clicking on the OK button did not install the keyboard. Seems to be an issue.

I have attached the Screenshot as well as the Video file for reference.

https://user-images.githubusercontent.com/19683143/222721120-3164429b-de2c-462b-9c99-c6843639b9df.mp4

Expected behavior

Keyman Configuration should install Galaxie Greek / Hebrew Keyboard without showing any warning (?) message.

Related issues

No response

Keyman apps

Keyman version

17.0.60-alpha

Operating system

Windows 10 OS (Native machine)

Device

Windows Desktop

Target application

No response

Browser

No response

Keyboard name

Galaxie Greek / Hebrew (Positional)

Keyboard version

No response

Language name

No response

Additional context

No response

rc-swag commented 1 year ago

I can replicate this. Some further notes for the investigation. If you hit cancel instead of pressing the install button again, although the keyboard layout tab is not updated with the Galaxie keyboard. If you exit Keyman Configuration and come back in, the keyboard is actually installed but with no language. Other keyboards would have installed but used systems default language instead.

bharanidharanj commented 1 year ago

I can replicate this. Some further notes for the investigation. If you hit cancel instead of pressing the install button again, although the keyboard layout tab is not updated with the Galaxie keyboard. If you exit Keyman Configuration and come back in, the keyboard is actually installed but with no language. Other keyboards would have installed but used systems default language instead.

@rc-swag Thanks for reproducing this issue.

rc-swag commented 1 year ago

This issue will become lower priority after this ticket is completed #9422 which will increase the transient languages to 12. It will need to be retested though.

rc-swag commented 9 months ago

Let's move this to be done after https://github.com/keymanapp/keyman/issues/9422