keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
394 stars 109 forks source link

feat(windows): make system tray icon a static icon rather than changing with the keyboard (as a flag) #859

Open MayuraVerma opened 6 years ago

MayuraVerma commented 6 years ago

System tray icon changes from "keyman" to installed keyboard if it has an icon.

At that point, there will be two icons which will be same. One in language bar and other in system tray.

One in language doesn't bring configuration on right click, One in system tray brings the configuration on right click

This can lead to confusion.

Please do not let the keyman engine in system tray change its icon based on the keyboard.

system try icon of Keyman engine must always have its icon.

mcdurdin commented 6 years ago

Thank you for the feedback. We'll take this into consideration in a future version of Keyman.

MayuraVerma commented 5 years ago

@mcdurdin @darcywong00

Please reconsider this request for windows app.

Keyman app icon in system try should retain its icon. If it picks the icon of the language, then there will be two icons in system tray. When user want to enter the menu of keyboard or system language settings, he/she will be confused.

Many users will think that they are two application running and will try to close one of them.

Please retain the keyman icon in system icon, irrespective of the keyboard chosen.

mcdurdin commented 5 years ago

This is still under consideration for a future version. The thing is, we have many, many users who are used to the Keyman icon changing with the language. So while I understand what you are saying, it may be a difficult transition for them.

From Windows 8 onward, the visibility of the language selector is much better, so this is probably less of a problem than it used to be. It may be we can introduce this as an option in Keyman 13, and then make it the default option in Keyman 14, or something like that.

MayuraVerma commented 4 years ago

This issue was closed. However, this is not resolved yet. Please review.

mcdurdin commented 4 years ago

While this would be an appropriate change in many ways, there is a cost to making the change, and currently other items are significantly higher priority. Also, it would change the workflow and understanding of Keyman for many thousands of existing users, and so it's not something we'll change lightly.

MayuraVerma commented 2 years ago

Any changes to this request. Please try to add at least flag to change this behavior in the configuration.

mcdurdin commented 2 years ago

We haven't yet made any changes here. When we drop support for Win7, Win8, Win8.1 would be a good time to do this.

We will probably drop support for those versions of Windows this year. We'll keep this under consideration.

MayuraVerma commented 2 years ago

I am listing the end of life dates which you are already aware.

Support for Windows 7 and 8 have already ended Windows 8.1 will reach the end of support on January 10, 2023.

image

Does Keyman Version 16, intend to support any of these Windows versions?

Please do not consider support for these older versions of Windows in Keyman V16.

mcdurdin commented 2 years ago

We are not prioritising dropping support for existing operating systems. Given 12% of users according to your starts are still on Windows 7 -- and we have a significant proportion of users on older versions -- we are not in a hurry to drop support unless we have to.

mcdurdin commented 2 years ago

If you would like to contribute a PR to make this an option, we'd love to take a look!

MayuraVerma commented 6 months ago

image

https://en.wikipedia.org/wiki/Template:Windows_usage_share

https://gs.statcounter.com/os-version-market-share/windows/desktop/worldwide

Windows 7 usage has dropped to 3% as off March 2024.

Could we please review this request

I can work on PR, please let me know if it is OK to do so.