search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
372 stars 102 forks source link

chore(windows): remove legacy core and flag ⛏️ #8593

Closed rc-swag closed 1 year ago

rc-swag commented 1 year ago

Fixes: #5442

Removing the legacy code that was replaced by the core. Also removing the feature flag for core integration.

User Testing

This will require a full acceptance test just to insure coverage of all the functionality.

Keyman for Windows Acceptance Test Procedures

  1. These test procedures are to be run before moving from alpha to beta, or beta to stable, or before PRs are merged into stable branches.

  2. Results are annotated with results, use > at the start of a new line under the checkbox/Test to note the result.

User Testing

Gather Assets for Testing

Setup Steps

  1. Uninstall previous versions of Keyman Desktop and Keyman Developer on the system
  2. Restart the system, install updates
  3. Make sure all additional Windows languages are removed
  4. Make sure no debug flags are set in HKCU/Software/Keyman/Debug

SUITE_BASELINE: Keyman for Windows Base Line Tests

Test cases

click to expand - **TEST_INSTALL**: - Install test build keyman-a.b.c.exe - Make sure Keyman is started and visible in the Notification area - **TEST_KEYBOARD_INSTALLATION_REMOTE**: - Start Keyman Configuration - Click Download Keyboard, select a keyboard from the download dialog and install it - If the package includes a readme file, verify that it appears in the install window. - If the package includes a welcome file, verify that it appears after installation. - Click OK to close Keyman Configuration - Start Notepad - Verify that the newly installed keyboard appears in the Keyman menu and can be selected - **TEST_INSTALL_PKG_DISK**: - Install a package from disk ## - Locate a .kmp file on disk and double-click to install it - If the package includes a readme file, verify that it appears in the install window. - If the package includes a welcome file, verify that it appears after installation. - Start Notepad - Verify that the keyboard appears in the Keyman menu - **TEST_KEYBOARD_OUTPUT**: - Start Notepad and select a Keyman keyboard (testing Legacy integration) - Verify that various test sequences are output correctly - Start Word and select a Keyman keyboard (testing TSF integration) - Verify that various test sequences are output correctly - **TEST_ON_SCREEN_KEYBOARD**: - Click Keyman icon in Notification area, select On Screen Keyboard - Verify that OSK displays correctly for selected Keyman keyboard - Verify that typing characters by clicking on OSK produces expected output

SUITE_CAPSLOCK:

Caps Lock

The test keyboard layouts are found in the keyman repo at app/windows/src/test/manual-tests/caps-lock-stores. There is a project file for the 3 keyboards used in this test. The project file can be used to build the keyboard packages, but you can conveniently use the .kmp file zipped and included respectively below.

The test cases below expect the usage of the capslock.kmp.zip keyboard. That keyboard outputs pass or fail if following the test cases.

Prerequisites before each test

Test cases

click to expand - **TEST_CAPSLOCK-1**: uppercase with virtual key - press and release `a` Expected result: - `pass.` (with other keyboards uppercase `A`) - **TEST_CAPSLOCK-2**: lowercase with virtual key - press and hold 'Shift' - press and release `b` - release `Shift` Expected result: - `pass.` (with other keyboards lowercase `b`) - **TEST_CAPSLOCK-3**: capslock ignored for numbers - press and hold 'Shift' - press and release `3` - release `Shift` Expected result: - `pass.` (with other keyboards `#`) - **TEST_CAPSLOCK-4**: uppercase - press and release `c` Expected result: - `pass.` (with other keyboards uppercase `C`) - **TEST_CAPSLOCK-5**: lowercase - press and hold 'Shift' - press and release `d` - release `Shift` Expected result: - `pass.` (with other keyboards lowercase `d`)

CapsAlwaysOff

For these tests, use a keyboard with the caps_always_off.kmp.zip store set. We call this keyboard capsalwaysoff below.

Any keyboard with that store set will work; if you don't have one at hand you can use the caps_always_off.kmp keyboard. The caps_always_off.kmp keyboard will prevent switching caps lock on. As a sanity check to verify that Keyman is actually active, pressing the key a will output ncaps_little_a, and Shift+a will output ncaps_shift_A.

Note: When testing in a virtual machine, use an on-screen keyboard (in VirtualBox: Input/Keyboard/Soft Keyboard) and observe the caps lock indicator of the on-screen keyboard. Using the hardware keyboard might show side effects with caps lock.

Prerequisites before each test

Test cases

click to expand - **TEST_CAPSOFF-1**: sanity check - switch to capsalwaysoff keyboard - press and release `a` Expected result: - output: `ncaps_little_a` - **TEST_CAPSOFF-2**: caps lock stays off - switch to capsalwaysoff keyboard - press and release `CapsLock` key - press and release `a` Expected result: - caps lock indicator stays turned off - output: `ncaps_little_a` - **TEST_CAPSOFF-3**: no caps lock while holding capslock key - switch to capsalwaysoff keyboard - press and hold `CapsLock` key - press and release `a` - release `CapsLock` key Expected result: - output: `ncaps_little_a` - **TEST_CAPSOFF-4**: no caps lock while holding capslock key - switch to capsalwaysoff keyboard - press and hold `CapsLock` key - press and hold `Shift` key - press and release `a` - release `CapsLock` and `Shift` keys Expected result: - output: `ncaps_shift_A` - **TEST_CAPSOFF-5**: switching turns off caps lock - turn on caps lock - switch to capsalwaysoff keyboard - press and release `a` Expected result: - caps lock indicator turned off - output: `ncaps_little_a`

SHIFT: CapsOnOnly/ShiftFreesCaps

For these tests, use a keyboard with the CapsOnOnly and ShiftFreesCaps stores set. We call this keyboard _shift_freescaps below.

Any keyboard with these stores set will work; if you don't have one at hand you can use the shift_frees_caps.kmp.zip keyboard.

The _shift_freescaps.kmp keyboard will enable caps lock by pressing the CapsLock key, and will turn capslock off by pressing the Shift key. The keyboard outputs pass or fail if following the test cases.

Note: When testing in a virtual machine, use an on-screen keyboard (in VirtualBox: Input/Keyboard/Soft Keyboard) and observe the caps lock indicator of the on-screen keyboard. Using the hardware keyboard might show side effects with caps lock. Except for TEST_CAPSONLY-5 which can only be reliably tested on a hardware keyboard on host OS (not a VM). For windows 10 and windows 11 with a virtual box vm-onscreen keyboard, the following happens. The VM soft keyboard does NOT actually send the Shift Shift Key Stroke through but rather will change the keys pressed for example if an a is pressed the soft keyboard itself will change that key to a A. This means we can't Test TEST_CAPONLY-5 on a soft keyboard.

Prerequisites before each test

Test cases

click to expand - **TEST_CAPSONLY-1**: no caps - press and release `1` Expected result: - output: `pass.` - **TEST_CAPSONLY-2**: caps - press and release `CapsLock` - press and release `2` Expected result: - caps lock indicator turned on - output: `pass.` - **TEST_CAPSONLY-3**: caps doesn't toggle - press and release `CapsLock` - press and release `CapsLock` - press and release `6` Expected result: - caps lock indicator turned on - output: `pass.` - **TEST_CAPSONLY-4**: shift turns off - press and release `CapsLock` - press and hold `Shift` - press and release `3` - release `Shift` Expected result: - caps lock indicator turned off - output: `pass.` - **TEST_CAPSONLY-5**: shift by itself turns off Be aware of limitations when testing this on virtual machines as noted above. - press and release `CapsLock` - press and release `Shift` Expected result: - caps lock indicator turned off - (no output)

SUITE_TSF_APP:

Background: Some windows applications use the windows TSF these include: MS Word, Firefox, Fieldworks and the windows search field on the taskbar.

Setup Text Services Framework(TSF) testing with Keyman for Windows

  1. Install Keyman Developer version 15 or greater.

  2. Open the Keyman Developers Test page in Firefox. It must be Firefox Browser

    i. By default this is at localhost:8008 so you could type this location in to the firefox address bar.

    ii. You can also access it by pressing the Test package on web button found in the Compile tab for any keyboard package.

  3. On the Keymand Developer Keyboard Test Page use the Keyboard dropdown to select system keyboard

  4. Use the Keyman for Windows icon located in the System Tray to select the desired Keyman for the Windows keyboard. system_tray

  5. Typing text into the input field will now use the TSF with the keyboard selected in step 4.

Test cases: double processing

click to expand To run these tests the EuroLatin (SIL) Keyboard from [here](https://keyman.com/keyboards/sil_euro_latin). - GROUP_WIN10 - GROUP_WIN11 - **TEST_DOUBLE_PROCESSING_FIREFOX**: 1. Follow steps 1-4 from `Setup Text Services Framework(TSF) testing with Keyman for Window` above selecting the EuroLatin Keyboard at step 4. 2. Select the EuroLatin Keyboard 3. Type in to the windows search bar `a` `b` `c` `d` Backspace 4. Expected result is `abc` - **TEST_DOUBLE_PROCESSING_SEARCHBAR**: 1. Start Keyman 2. Select the EuroLatin Keyboard 3. Type in to the windows search bar `a` `b` `c` `d` Backspace 4. Expected result is `abc` ![Search_bar](https://user-images.githubusercontent.com/58423624/152917408-785a34be-ad1e-4e06-bcc6-bea2bd86d70d.png) - **TEST_DOUBLE_PROCESSING_NOTEPAD**: 1. Open Notepad 2. Start Keyman 2. Select the EuroLatin Keyboard 3. Type a sequence of letters `a` `b` `c` `d` 4. Expected result: `abcd` ---

SUITE_IMX_KEYBOARDS

Test IMX keyboards still work after core integration. see tests suite on #5936 and also #6187

This is the keyboard to be tested. imsample.zip If an IMTest keyboard is already installed you will need to uninstall it first, restart windows and then install the Imsample keyboard attached to this PR.

I have copied the tests from #5936 and made a few modifications.
The overall test we are aiming for is that in doing the tests below the keyboard does not cause a keyman or app crash.

Test cases

click to expand #### IMSAMPLE_KEYBOARD_INLINE_MENU: This keyboard uses the letters `aeom` to allow IMX input. This keyboard is a bit flakey being a demo and not polished. It also takes some setting up the following registry keys need to be added and set once installed. The location of the registry keys are at. `Computer\HKEY_CURRENT_USER\SOFTWARE\Keyman\Keyman Engine\Active Keyboards\imsample` and are of type REG_DWORD The keys are `ShowIMWindow` and `ShowIMWindowAlways` they both need to be set to 0. In this mode IM window is not shown rather the app text is updated with a menu when either `aeom` is pressed. For example when type `he` the text will become `h[1ɛ 2ɜ 3ə 4e 5ɘ]` then you type the number `3` the text displayed should now be `hə` * **TEST_IMSAMPLE_INPUT:** - Install Imsample keyboard attached to this PR. - Select the keyboard its name is `IMTest` - Type some keys that are not the special keys e.g. `t` `r` `y` - - Type the `space` key then `a` then type 1 to get the 1st option - Expected Result: `try æ` - continue to the next test * **TEST_IMSAMPLE_INPUT_CONT:** ... contd from above - Type 'm' and type 3 to get `###` option - Expected Result: `try æ###` * **TEST_IMSAMPLE_BACKSPACE:** Using Notepad or Libreoffice - Type `f` - Type `e` - The screen should have f[1ɛ 2ɜ 3ə 4e 5ɘ] - Now press Backspace. the whole option menu including the square brackets `[` `]` should be deleted. - Expected result `f` #### IMSAMPLE_KEYBOARD_IM_WINDOW: This keyboard uses the letters `aeom` to allow IMX input. This time a IM window should display. ![image](https://user-images.githubusercontent.com/58423624/157192172-2ba2d0e4-8917-49b3-9709-00d7e9014645.png) The first time you use the keyboard with an application the registry keys will be created and by default set to 1. If the IM window is not appearing you will need to verify the value of two registry keys. The location of the registry keys are at. `Computer\HKEY_CURRENT_USER\SOFTWARE\Keyman\Keyman Engine\Active Keyboards\imsample` and are of type REG_DWORD The keys are `ShowIMWindow` and `ShowIMWindowAlways` they both need to be set to 1. Note for the IM window you need to use the mouse pointer to select the options, you can't type the number. * **TEST_IMSAMPLE_INPUT_IMW:** - Install Imsample keyboard attached to this PR (if not done already) - Select the keyboard its name is `IMTest` - Type some keys that are not the special keys e.g. `t` `r` `y` - Type the `space` key then `a` then click the 1st option - Expected Result: `try æ` - continue to the next test * **TEST_IMSAMPLE_INPUT_IMW_CONT:** ... contd from above - Type 'm' and select the 3rd `###` option - Expected Result: `try æ###` #### SIMPLIFIED_CHINESE: This keyboard will display the IMX window as soon as a string the matches the pinyin for one or more characters are typed. For all these tests install the Simplified Chinese Keyboard cs-pinyin.cmp found [here](https://keyman.com/keyboards/cs-pinyin) * **TEST_SIMPLIFIED_CHINESE_SINGLE**: Using Notepad or equivalent. - Type `o` - The IMX window should appear - Choose the 4th option - Expected result: 喔 * **TEST_SIMPLIFIED_CHINESE_MULTIPLE**: Using Notepad or equivalent. - Type `h` `a` `n` `z` `i` - The IMX window will appear and in the top left the letters `hanzi` will be present - Choose the 5th option - Expected result: 汉字变换 * **TEST_SIMPLIFIED_CHINESE_BACKSPACE_1**: Using Notepad or equivalent. This is to test the backspace occurring mid pinyin sequence before a character is output to the app - Type `h` `a` `n` `z` `i` - The IMX window will appear and in the top left the letters `hanzi` will be present - Press Backspace twice - The IMX window should now have the top left letters of `han`. - Choose the 5th option - Expected result: 汗 * **TEST_SIMPLIFIED_CHINESE_BACKSPACE_2**: Using Notepad or equivalent. This is to test the backspace of already output characters. - Type `h` `a` `n` `z` `i` - The IMX window will appear and in the top left the letters `hanzi` will be present. - Choose the 5th option - Expected result: 汉字变换 - Press Backspace twice - Expected result: 汉字

SUITE_STORE_AND_CONTEXT

Test the options keyboard stores and context updating as a result of keystroke input. Introduced after #7077 and #7809 there are more tests on those PRs.

Test cases

click to expand The key referred to as "enter" is alternatively labelled "return" on some keyboards. Keyboards for the following test are found in the zip file [store_context_kbd.zip](https://github.com/keymanapp/keyman/files/9441852/store_context_kbd.zip) **TEST_21_OPTION_STORE:** 1. Install **021 - options.kmx** 2. Open Notepad 3. Select 021-options.kmx as the current keyboard. 4. Type a1a0a Expected Result: "no foo.foo.no foo" **TEST_OUTPUT_KEYSTROKE** 1. Install **043 - output and keystroke.kmx** 2. Open Notepad 3. Select 043 - output and keystroke.kmx as the current keyboard. 4. Type 123 Expected Result: "abd3" **TEST_OUTPUT_KEYSTROKE_INVALID_CONTEXT** 1. If not installed from the previous test - Install **043 - output and keystroke.kmx** 2. Open Notepad 3. Select 043 - output and keystroke.kmx as the current keyboard. 4. Type 12Enter3 Expected Result: \ "abc\ 3" **TEST_DEADKEY_AND_CONTEXT** 1. Install **045 - deadkey and context.kmx** 2. Open Notepad 3. Select 045 - deadkey and context.kmx as the current keyboard. 4. Type yzShift+/ Expected Result: "correct"
keymanapp-test-bot[bot] commented 1 year ago

User Test Results

Test specification and instructions

✅ SUITE_BASELINE: Keyman for Windows Base Line Tests

10 tests in 2 groups PASSED * ✅ GROUP_WIN10:
5 tests PASSED - ✅ **TEST_INSTALL ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1516408130))**: Tested with the attached Keyman build (17.0.87-alpha-test-8593) in Windows 10 OS and I was able to installed this build without having any problem. - ✅ **TEST_KEYBOARD_INSTALLATION_REMOTE ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1516408130))**: Able to install Khmer Angkor keyboard using Download Keyboard button in the Keyman Configuration dialog. - ✅ **TEST_INSTALL_PKG_DISK ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1516408130))**: Able to install sil_ipa.kmp file from a folder. Verified that the keyboard appears on the menu. - ✅ **TEST_KEYBOARD_OUTPUT ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1532767386))**: Tested with the attached PR build (17.0.87-alpha-test-8593) in Windows 10 OS and here is my observation: 1. Able to see the Khmer keyboard in both Keyman Configuration dialog as well as in the Keyman menu list in the task bar. 2. Able to type in both the keyboard using Notepad app. Seems to be working fine. ([notes](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1532767386)) - ✅ **TEST_ON_SCREEN_KEYBOARD ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1516448533))**: Verified that OSK displayed correctly for the selected keyboard. Able to type in the Notepad using OSK.
* ✅ GROUP_WIN11:
5 tests PASSED - ✅ **TEST_INSTALL ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517678549))**: Tested with the attached Keyman build (17.0.87-alpha-test-8593) in Windows 11 OS (Virtual Machine) and I was able to installed this build without having any problem. - ✅ **TEST_KEYBOARD_INSTALLATION_REMOTE ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517678549))**: Able to install Khmer Angkor keyboard using Download Keyboard button in the Keyman Configuration dialog. - ✅ **TEST_INSTALL_PKG_DISK ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517678549))**: Able to install sil_ipa.kmp file from a folder. Verified that the keyboard appears on the menu. - ✅ **TEST_KEYBOARD_OUTPUT ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517678549))**: Able to change the keyboards and type it in the relevant language in the Notepad. - ✅ **TEST_ON_SCREEN_KEYBOARD ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517678549))**: Verified that OSK displayed correctly for the selected keyboard. Able to type in the Notepad using OSK.

✅ SUITE_CAPSLOCK:

30 tests in 2 groups PASSED * ✅ GROUP_WIN10:
15 tests PASSED - ✅ **TEST_CAPSLOCK-1 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSLOCK-2 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSLOCK-3 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSLOCK-4 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSLOCK-5 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSOFF-1 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'ncaps_little_a' result shown in the Notepad. - ✅ **TEST_CAPSOFF-2 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'ncaps_little_a' result shown in the Notepad. - ✅ **TEST_CAPSOFF-3 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'ncaps_little_a' result shown in the Notepad. - ✅ **TEST_CAPSOFF-4 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'ncaps_shift_A' result shown in the Notepad. - ✅ **TEST_CAPSOFF-5 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'ncaps_little_a' result shown in the Notepad. - ✅ **TEST_CAPSONLY-1 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSONLY-2 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSONLY-3 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSONLY-4 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSONLY-5 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517467013))**: Verified that nothing has output in the Notepad.
* ✅ GROUP_WIN11:
15 tests PASSED - ✅ **TEST_CAPSLOCK-1 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSLOCK-2 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSLOCK-3 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSLOCK-4 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSLOCK-5 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSOFF-1 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'ncaps_little_a' result shown in the Notepad. - ✅ **TEST_CAPSOFF-2 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'ncaps_little_a' result shown in the Notepad. - ✅ **TEST_CAPSOFF-3 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'ncaps_little_a' result shown in the Notepad. - ✅ **TEST_CAPSOFF-4 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'ncaps_shift_A' result shown in the Notepad. - ✅ **TEST_CAPSOFF-5 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'ncaps_little_a' result shown in the Notepad. - ✅ **TEST_CAPSONLY-1 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSONLY-2 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSONLY-3 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSONLY-4 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that 'pass' result shown in the Notepad. - ✅ **TEST_CAPSONLY-5 ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517730219))**: Verified that nothing has output in the Notepad.

✅ SUITE_TSF_APP:

6 tests in 2 groups PASSED * ✅ GROUP_WIN10:
3 tests PASSED - ✅ **TEST_DOUBLE_PROCESSING_FIREFOX ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517585586))**: Verified that it shows the expected result abc - ✅ **TEST_DOUBLE_PROCESSING_SEARCHBAR ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517585586))**: Verified that it shows the expected result abc - ✅ **TEST_DOUBLE_PROCESSING_NOTEPAD ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517585586))**: Verified that it shows the expected result abcd
* ✅ GROUP_WIN11:
3 tests PASSED - ✅ **TEST_DOUBLE_PROCESSING_FIREFOX ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517788460))**: Verified that it shows the expected result abc - ✅ **TEST_DOUBLE_PROCESSING_SEARCHBAR ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517788460))**: Verified that it shows the expected result abc - ✅ **TEST_DOUBLE_PROCESSING_NOTEPAD ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517788460))**: Verified that it shows the expected result abcd

🟥 SUITE_IMX_KEYBOARDS:

✅ SUITE_STORE_AND_CONTEXT:

8 tests in 2 groups PASSED * ✅ GROUP_WIN10:
4 tests PASSED - ✅ **TEST_21_OPTION_STORE ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517609997))**: Verified the expected result shown 'no foo.foo.no foo' in the Notepad. - ✅ **TEST_OUTPUT_KEYSTROKE ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517609997))**: Verified the expected result is 'abcd3' - ✅ **TEST_OUTPUT_KEYSTROKE_INVALID_CONTEXT ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517609997))**: Verified the expected result is ([notes](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517609997)) - ✅ **TEST_DEADKEY_AND_CONTEXT ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1517609997))**: Verified the expected result is 'correct'
* ✅ GROUP_WIN11:
4 tests PASSED - ✅ **TEST_21_OPTION_STORE ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1519603039))**: Verified the expected result shown 'no foo.foo.no foo' in the Notepad. - ✅ **TEST_OUTPUT_KEYSTROKE ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1519603039))**: Verified the expected result is 'abcd3' - ✅ **TEST_OUTPUT_KEYSTROKE_INVALID_CONTEXT ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1519603039))**: Verified the expected result is ([notes](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1519603039)) - ✅ **TEST_DEADKEY_AND_CONTEXT ([PASSED](https://github.com/keymanapp/keyman/pull/8593#issuecomment-1519603039))**: Verified the expected result is 'correct'
Retesting Template ``` @keymanapp-test-bot retest SUITE_IMX_KEYBOARDS GROUP_WIN11 TEST_IMSAMPLE_INPUT TEST_IMSAMPLE_INPUT_CONT TEST_IMSAMPLE_BACKSPACE TEST_IMSAMPLE_INPUT_IMW TEST_IMSAMPLE_INPUT_IMW_CONT TEST_SIMPLIFIED_CHINESE_SINGLE TEST_SIMPLIFIED_CHINESE_MULTIPLE TEST_SIMPLIFIED_CHINESE_BACKSPACE_1 TEST_SIMPLIFIED_CHINESE_BACKSPACE_2 ```

Test Artifacts

bharanidharanj commented 1 year ago

SUITE_BASELINE: Keyman for Windows Base Line Tests

GROUP_WIN10:

bharanidharanj commented 1 year ago

SUITE_BASELINE: Keyman for Windows Base Line Tests

GROUP_WIN10:

mcdurdin commented 1 year ago

I think we can remove LPKEYBOARD Keyboard; from tagINTKEYBOARDINFO in keymanengine.h, along with deleting legacy_kmx_memory.h altogether, yes? And that should filter out a bunch of other obsolete bits and pieces I think? Should we also be removing all references to legacy_kmx_file.h?

mcdurdin commented 1 year ago

addins.cpp/addins.h should also be deleteable I think

bharanidharanj commented 1 year ago

SUITE_CAPSLOCK:

GROUP_WIN10:

bharanidharanj commented 1 year ago

SUITE_TSF_APP:

GROUP_WIN10:

bharanidharanj commented 1 year ago

SUITE_IMX_KEYBOARDS:

GROUP_WIN10:

bharanidharanj commented 1 year ago

SUITE_STORE_AND_CONTEXT:

GROUP_WIN10:

bharanidharanj commented 1 year ago

SUITE_BASELINE: Keyman for Windows Base Line Tests

GROUP_WIN11:

bharanidharanj commented 1 year ago

SUITE_CAPSLOCK:

GROUP_WIN11:

bharanidharanj commented 1 year ago

SUITE_TSF_APP:

GROUP_WIN11:

bharanidharanj commented 1 year ago

SUITE_IMX_KEYBOARDS:

GROUP_WIN11:

mcdurdin commented 1 year ago

Developer build failure can be ignored -- due to updated build.sh pack command for local build of npm packages; this will be available once merged.

bharanidharanj commented 1 year ago

SUITE_IMX_KEYBOARDS:

GROUP_WIN11:

bharanidharanj commented 1 year ago

Test Results

SUITE_STORE_AND_CONTEXT:

GROUP_WIN11:

rc-swag commented 1 year ago

@bharanidharanj I have reproduced the failures you have found and will move this back to draft to investigate.

rc-swag commented 1 year ago

I made mistake when removing the addin.h/addin.c from the project. In the hook message for UNI_CHAR I should have simply done nothing. However, I moved to the text message. Regardless I have reverted the commit and created a separate PR just to remove addins for easier tracking. It can simply cherry-pick the commit but handle the message correctly.

rc-swag commented 1 year ago

@keymanapp-test-bot retest SUITE_BASELINE GROUP_WIN10 TEST_KEYBOARD_OUTPUT

rc-swag commented 1 year ago

In Investing the failed test for Windows 11 on SUITE_IMX_KEYBOARDS it appears that these tests also fail for Keyman 14 and 16. Issue #8697 has been created to address this issue.
So the failing SUITE_IMX_KEYBOARDS , GROUP_WIN11 will be addressed in issue #8697

rc-swag commented 1 year ago

Since @mcdurdin last approved it 3 commits have been made and it is now ready for review again.
In an attempt to keep this PR from getting harder to review, the following separate issues have been made.

The failing SUITE_IMX_KEYBOARDS , GROUP_WIN11 will be addressed in issue #8697. This is not a result of this PR but rather discovered in testing this PR.

bharanidharanj commented 1 year ago

@bharanidharanj I have reproduced the failures you have found and will move this back to draft to investigate.

Okay, Thanks @rc-swag

bharanidharanj commented 1 year ago

Test Results

SUITE_BASELINE: Keyman for Windows Base Line Tests

GROUP_WIN10:

rc-swag commented 1 year ago

The failed tests fail currently on Windows 11 with Keyman 15 and up. https://github.com/keymanapp/keyman/issues/8697 has been created to deal with this. Therefore can merge this PR.

keyman-server commented 1 year ago

Changes in this pull request will be available for download in Keyman version 17.0.109-alpha