keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
394 stars 110 forks source link

chore(ios): `tools/prepRelease.sh: line 109: RELEASE_OEM_FIRSTVOICES: unbound variable` #9051

Open mcdurdin opened 1 year ago

mcdurdin commented 1 year ago

The RELEASE_OEM_FIRSTVOICES env variable should be verified for existence, and if possible we should eliminate one of RELEASE_OEM and RELEASE_OEM_FIRSTVOICES env vars.

Ref: https://build.palaso.org/buildConfiguration/Keyman_iOS_TestPullRequests/390387?buildTab=log&focusLine=1985&linesState=1974&logView=flowAware

Note that this only arises if the RELEASE_OEM_FIRSTVOICES variable is not defined, e.g. if we've decided not to build FV. But it seems that both those variables need to be managed. Warning: this applies also to FV Android and FV Windows -- so we need to make it consistent across all platforms.

(Longer term: separate out FV builds into their own Build Configurations)

sgschantz commented 1 month ago

moving to sprint focused on ios