search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
391 stars 108 forks source link

chore(common): S_Splash_Start string should not localize the name "Keyman" for Kannada #9635

Closed rc-swag closed 1 month ago

rc-swag commented 1 year ago 
          > @darcywong00 Do we translate trademark names like "Keyman"

No, that should stay as 'Keyman', 'Windows' as 'Windows' etc.

Originally posted by @mcdurdin in https://github.com/keymanapp/keyman/issues/9481#issuecomment-1720816693

darcywong00 commented 1 year ago

Currently in crowdin, the entire S_Splash_Start string "Start Keyman" gets localized.

You may need to change the S_Splash_Start string to "Start %1$s". And then format "Keyman" into the string.

Unfortunately, this impacts a lot of other strings :disappointed:

darcywong00 commented 12 months ago

From A17S23 sprint plan meeting, team decided this is low-priortity and just busy-work.

It would be preferable to have a way on crowdin to tell translators not to translate "Keyman"...

rc-swag commented 12 months ago

It would be preferable to have a way on crowdin to tell translators not to translate "Keyman"...

Yes. Less important but, useful for Phone UI's is a away to set a maximum number of characters for the localisation.

darcywong00 commented 1 month ago

While looking at this, I see there's also a string S_Splash_Name for "Keyman". Maybe we should designate this as not to translate too.

I've made the fix/windows/crowdin-hide-strings branch for @rc-swag to investigate using a new "S_Splash_Start_2" string instead of "SP_Splash_Start".

And maybe hardcode "Keyman" where "S_Splash_Name" is used