search

keymanapp / keymanweb.com

https://keymanweb.com/ source
2 stars 2 forks source link

feat: use shared sites infrastructure #83

Closed mcdurdin closed 8 months ago

mcdurdin commented 9 months ago

Note: consolidation of build.sh steps will come in a future PR. This just removes the duplicated files and uses the shared files instead.

Relates to:

darcywong00 commented 9 months ago

Ah, I should probably abandon #81 since the code is now moved to shared-sites. We may want to review some subtle differences for TIER_TEST where I was planning to use

$this->keymanweb_com = "http://host.docker.internal:8057"; // Unique for keymanweb.com
mcdurdin commented 9 months ago

We may want to review some subtle differences for TIER_TEST where I was planning to use

Yes, I definitely don't want those to diverge between sites. We should probably redo the way the whole set is defined...

darcywong00 commented 9 months ago

I think this override still needs to be in place for testing?

$this->keymanweb_com = "http://host.docker.internal:8057";

mcdurdin commented 9 months ago

I think this override still needs to be in place for testing?

$this->keymanweb_com = "http://host.docker.internal:8057";

Tests are passing so I don't think it needs the override. That would only really be needed if we had REST calls to itself?

darcywong00 commented 8 months ago

Tests are passing so I don't think it needs the override

It seems TIER_TEST would then be running tests on the live keymanweb.com site instead of proposed local changes on a PR?

https://github.com/keymanapp/shared-sites/blob/c7586ec649f3766e4aece1a02b7d3aa148bf7859/_common/KeymanHosts.php#L126-L133

darcywong00 commented 8 months ago

ah nvm, I see ci.yml is already using host.docker.internal...