keymanapp / lexical-models

Lexical language models for predictive text
MIT License
13 stars 38 forks source link

change: [nrc.en.mtnt] correction-searching now ignores quotes, apostrophes #244

Closed jahorton closed 8 months ago

jahorton commented 8 months ago

Fixes #229.

https://github.com/keymanapp/keyman/pull/10935 includes the updated model in the main repo's "Predictive text - robust testing" KMW test page.

image

image

If we have a perfect match, we run with that:

image

The real test, as someone born and raised in Louisiana:

image

Sadly, the classic y'all'd've is not included in this lexical model. Fortunately, it has the correct y'all (freq: 152) listed ahead of the impostor ya'll (freq: 6).

... it's tempting to go ahead and merge them myself, but that may belong as a separate fix.

jahorton commented 8 months ago

So, this part does not need a change, right?

https://github.com/keymanapp/lexical-models/blob/9dbc7b7d8a32582e689d45496c7ebff7e2237a8f/release/nrc/nrc.en.mtnt/nrc.en.mtnt.kpj#L11-L17

mcdurdin commented 8 months ago

So, this part does not need a change, right?

Correct, the .kpj metadata is only used by the Keyman Developer IDE.

mcdurdin commented 8 months ago

Also HISTORY.md needs updating