keymanapp / lexical-models

Lexical language models for predictive text
MIT License
13 stars 38 forks source link

teochow model submission #260

Closed Cathaylaboratory closed 3 months ago

Cathaylaboratory commented 3 months ago

here is my teochow model submission

keyman-server commented 3 months ago

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

DavidLRowe commented 3 months ago

Thanks for your submission.

I think that the project folder name can be just cathaylab.nan-latn.teochow (that is, without the -035 in the language tag), unless there is a different orthography for that region. @mcdurdin Can you confirm?

(And what is region 035?)

In order to fit in the structure of the repository your project folder (with name Author.LanguageTag.ModelName) needs to be under a folder with just the author name, so cathaylab.nan-latn.teochow would be the base folder for the project, and it would be in the folder cathaylab, which would in turn be under the release folder.

@mcdurdin Do we need to wait on new lexical models while you update the repository to use v17?

Cathaylaboratory commented 3 months ago

I think remain the 035 is important because Teochew is different with Taiwanese. 035 means southeast Asia.

Sent from Proton Mail for iOS

On Fri, Aug 16, 2024 at 03:54, DavidLRowe @.***> wrote:

Thanks for your submission.

I think that the project folder name can be just cathaylab.nan-latn.teochow (that is, without the -035 in the language tag), unless there is a different orthography for that region. @.***(https://github.com/mcdurdin) Can you confirm?

(And what is region 035?)

In order to fit in the structure of the repository your project folder (with name Author.LanguageTag.ModelName) needs to be under a folder with just the author name, so cathaylab.nan-latn.teochow would be the base folder for the project, and it would be in the folder cathaylab, which would in turn be under the release folder.

@.***(https://github.com/mcdurdin) Do we need to wait on new lexical models while you update the repository to use v17?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

Cathaylaboratory commented 3 months ago

I have change the name teochow to teochew to recorrect my false spelling. Have you received that?

Sent with Proton Mail secure email.

On Friday, 16 August 2024 at 7:45 AM, wongwanho @.***> wrote:

I think remain the 035 is important because Teochew is different with Taiwanese. 035 means southeast Asia.

Sent from Proton Mail for iOS

On Fri, Aug 16, 2024 at 03:54, DavidLRowe @.***> wrote:

Thanks for your submission.

I think that the project folder name can be just cathaylab.nan-latn.teochow (that is, without the -035 in the language tag), unless there is a different orthography for that region. @.***(https://github.com/mcdurdin) Can you confirm?

(And what is region 035?)

In order to fit in the structure of the repository your project folder (with name Author.LanguageTag.ModelName) needs to be under a folder with just the author name, so cathaylab.nan-latn.teochow would be the base folder for the project, and it would be in the folder cathaylab, which would in turn be under the release folder.

@.***(https://github.com/mcdurdin) Do we need to wait on new lexical models while you update the repository to use v17?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

mcdurdin commented 3 months ago

@mcdurdin Can you confirm?

I think that the region may be important in this case -- but then the keyboard will need to have that bcp47 listed in its registration also.

@mcdurdin Do we need to wait on new lexical models while you update the repository to use v17?

No, the repository should be ready for new lexical models.

Cathaylaboratory commented 3 months ago

The nan-latn-tw is different with nan-latn-035, I choose 035 to represent teochew because many teochew users lives in Thai, Vietnam, and Canton. I consider there is southeast asia, this model will only match the teochew keyboard. I don't want this model to match nan-latn-tw.

Sent with Proton Mail secure email.

On Friday, 16 August 2024 at 3:54 AM, DavidLRowe @.***> wrote:

Thanks for your submission.

I think that the project folder name can be just cathaylab.nan-latn.teochow (that is, without the -035 in the language tag), unless there is a different orthography for that region. @.***(https://github.com/mcdurdin) Can you confirm?

(And what is region 035?)

In order to fit in the structure of the repository your project folder (with name Author.LanguageTag.ModelName) needs to be under a folder with just the author name, so cathaylab.nan-latn.teochow would be the base folder for the project, and it would be in the folder cathaylab, which would in turn be under the release folder.

@.***(https://github.com/mcdurdin) Do we need to wait on new lexical models while you update the repository to use v17?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

mcdurdin commented 3 months ago

It might be better for compatibility reasons to list each of the regions separately, nan-latn-th, nan-latn-vn etc., rather than using the numeric region code