bug: markdown rewrite replaces own-site URLs with internal docker reference

keymanapp / shared-sites

Shared code across keyman.com sites

MIT License

0 stars 1 forks source link

bug: markdown rewrite replaces own-site URLs with internal docker reference #15

Closed mcdurdin closed 8 months ago

mcdurdin commented 9 months ago

from:

The .kvks file contained a virtual key that was not supported by
Keyman. Remove this virtual key from the .kvks file.

Supported virtual keys: https://help.keyman.com/developer/language/guide/virtual-keys#common-virtual-key-codes

(Note: the snippet in question is not yet live)

mcdurdin commented 8 months ago

This may only happen on development mode, doesn't seem to be happening on production.

darcywong00 commented 8 months ago

I think it's from this block (See also #6)

https://github.com/keymanapp/shared-sites/blob/88d06fc2fe56ae7cbec009a14aeff7dc37fbaa3e/_common/KeymanHosts.php#L142-L151

Maybe we don't replace if host is self?

mcdurdin commented 8 months ago

I think we should rely on website-local-proxy being running. We already do that for s.keyman.com in that code snippet. Then we shouldn't need to expose the host.docker.internal addresses at all?