search

keymanapp / status.keyman.com

https://status.keyman.com/
0 stars 0 forks source link

bug(testbot): "all checks passed" but open tests #443

Open srl295 opened 2 months ago

srl295 commented 2 months ago

playground repro: https://github.com/keymanapp/keymanapp-test-bot-playground/pull/14#issuecomment-2052094256

Production repro: https://github.com/keymanapp/keyman/pull/11172#issuecomment-2051712152

Repro steps:

  1. create PR with @keymanapp-test-bot skip
  2. later, remove the skip and add a test suite in a comment

unclear if an intermediate half-baked test suite in the description (in addition to the comment) is needed.

mcdurdin commented 2 months ago

It appears that if the text @keymanapp-test-bot skip is found anywhere in any comment in the PR, then the checks 'pass', although the labels show the actual state correctly.

I removed the @ from two comments (1, 2) in keymanapp/keyman#11172 and then status of checks was shown correctly.

mcdurdin commented 2 months ago

Will fix after beta release