ermshiperete
commented
1 month ago That might not be the only thing going on. It doesn't explain why PR #11536 isn't considered as contribution which was created on Friday 19:14 UTC+2 (Saturday 0:14 UTC+7). Or maybe that is because it was labeled as A18S2 (previous sprint) when it was created?
The contributions displayed on the status site don't always match the calculated contributions (notice the red 1 after "Contributions", but nothing showing up below):
This is on a machine with the time zone set to Germany (UTC+2). On a machine with Phnom Penh time zone (UTC+7) one review shows up:
The comment in #11535 was made on Friday at 19:03 German time (Saturday 0:03 Phnom Penh).
It looks like contributions are calculated based on Phnom Penh time, but displayed in local time.
It would be good if server and client would agree, i.e. if the client would always display contributions based on the same time zone as the server. This might lead to some contributions showing up on the "wrong" day. The reasoning behind this would be that the days displayed would be Phnom Penh time.
Another solution would be to show the days in local time but for the full sprint (starting at 0:00 Phnom Penh on Saturday and ending 23:59 Phnom Penh on Friday). This would lead to showing 15 days for a sprint for non-Phnom Penh time zones.