keymapperorg / KeyMapper

**DEVELOPMENT STOPPED**.📱 An Android app that change what the buttons do on your devices!
http://docs.keymapper.club
GNU General Public License v3.0
974 stars 149 forks source link

Make red error banner be dismissable on problem resolution #974

Open jstetten opened 2 years ago

jstetten commented 2 years ago

A requested follow-up issue from discussion in #938, (quoted text by @sds100):

If the user presses dismiss, do you think the green message should be dismissed forever or only dismissed until something goes wrong again?

Until something goes wrong again. To get real about it, the green box is really only informative for a very brief period of time, i.e. immediately after returning to the app after having successfully fixed the problem announced by the (helpful) red error box. I would guess that 5–15 seconds is plenty for most, but a swipe or tap to dismiss is no big deal.

On the other hand, to simplify things maybe no green message should be consistently shown. After you fix a problem, should a toast popup message just say that you fixed the problem?

I won't cry if you ditch it altogether, though it's still a nice-looking existing UI element that could be reused. Shizuku service status certainly fulfills the exact same red (problem)/green (resolution) logic scenario as admin permission, so there's that. Other colors (orange) could be used for less immediately dire warnings such as "Automatic backups encountered an error" or "the [keyboard/sound/app/etc.] is no longer available, please select another or delete/disable key map". Maybe even blue for informational messages (ambitious examples: "You installed Shizuku since last opening; would you like to enable extra features?" or "Heuristics show one or more of your key maps may be [interfering with each other's behavior / forming a recursive loop].").

I could brainstorm more but you get the idea.

Developer TODO (don't remove)

GL513 commented 2 years ago

I said somthing about this in the discord a while ago. Personally, if the way the notifications work is changed, i think it might be nice to have an advanced setting for it. To explain further, inside of the setting for the notification layouts, there would be a checkbox for "always hide", and a slider for how long it should be displayed, if " always hide" isnt checked. Of course, setting the slider to 0 would keep the notifications to default settings. Now that i think of it, an "always show" checkbox might be nice as well, mostly for debugging.