keymetrics / docker-pm2

🐳 Official Docker Image for PM2 runtime
https://hub.docker.com/r/keymetrics/pm2
MIT License
476 stars 60 forks source link

Embed v8-profiler into image #34

Open Unitech opened 7 years ago

Unitech commented 7 years ago

@simonepri what do you about adding v8-profiler module (via pm2 install v8-profiler) by default? It would allow to snapshot memory and run cpu profiling when needed

simonepri commented 7 years ago

Could you describe me an use scenario?

Unitech commented 7 years ago

If the v8-profiler is present in the container, PM2 allows to trigger heapdump and cpu profiling, that is a nice have to inspect what is going on in case of bad behaviors

Unitech commented 6 years ago

it does not work currently to RUN pm2 install profiler on alpine image because python & stuff are missing

simonepri commented 6 years ago

How pm2 install profiler works? It runs npm install v8-profiler ?

Unitech commented 6 years ago

Yes exactly and it also auto inject the profiler into the source code of the user allowing to retrieve heapdump/cpuprofile

On Wed, Jan 24, 2018 at 7:45 PM Simone Primarosa notifications@github.com wrote:

How pm2 install profiler works? It runs npm install v8-profiler ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/keymetrics/docker-pm2/issues/34#issuecomment-360233723, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuP87UQzHd9kHEq_q3LY9bfVm8m1hznks5tN3pNgaJpZM4OhudA .

-- Alexandre Strzelewicz (+33) 7.83.88.11.43