Not a drop in replacement?

keymetrics / pm2-io-apm

PM2.io APM for Node.JS

Apache License 2.0

147 stars 40 forks source link

Not a drop in replacement? #255

Closed bradennapier closed 5 years ago

bradennapier commented 5 years ago

This says that @pm2/io is a drop-in replacement but i see a bunch of differences at first glance. No ports, metrics moved to metrics property....

pmx.init({ network: true, ports: true }) is not pmx.init({ metrics: { network: true } }) and it looks like ports is not an option at all.

bradennapier commented 5 years ago

Additionally this doesnt work...

/** Track how many connected websockets are currently active. */
const connectedUsers = pmx.probe().metric({
  name: 'Connected Clients',
});

you should fix the info and provide a migration doc

Eywek commented 5 years ago

You can find migration guide here https://github.com/keymetrics/pm2-io-apm#migration-guides. I've updated it for the probe() method removed here