search

keymetrics / pm2-plus-tech-questions

http://docs.keymetrics.io/docs/pages/faq-troubleshooting/
27 stars 3 forks source link

Transaction Tracing: Format support request #188

Open p-j opened 6 years ago

p-j commented 6 years ago

Hi,

We've been testing Keymetrics very recently and found out that one of our "generic" route is not aggregated in the Transaction view.

Here are a few examples of path we use.

/files/849626/-/scale_crop/1024x632/center/-/progressive/yes/
/files/844578/-/scale_crop/710x420/center/-/progressive/yes/
/files/827985/-/scale_crop/350x250/center/-/progressive/yes/
/files/638429/-/scale_crop/350x250/center/-/progressive/yes/
/files/856488/-/scale_crop/350x250/center/-/progressive/yes/
/files/843496/-/scale_crop/68x68/center/-/progressive/yes/
/files/818394/-/scale_crop/68x68/center/-/progressive/yes/
/files/453337/-/scale_crop/68x68/center/-/progressive/yes/
/files/414197/-/scale_crop/1024x632/center/
/files/414197/-/resize/1000x600/

These are formated accordingly to Uploadcare's smart CDN capabilities.

What would work mainly in our case is to group with something like

/files/[0-9]+/-/.*

I understand this is too simple to work in a general usage like you handle, but I think the pattern of /-/ is key here to match the result. I can probably come up with a list of the current possible combination of action & parameters if needed.

vmarchaud commented 6 years ago

Thanks for bringing the problem here ! We will start working on a new tracing system soon and will take your request into account when making it

p-j commented 6 years ago

Ok, if I may suggest, it would be cool to have traces of external HTTP call made with popular libs such as request, axios etc... For architecture that are based on services communicating via HTTP that would be very cool to see what can be a performance bottleneck based on those wait times.