search

keymetrics / trassingue

(DEPRECATED)
Apache License 2.0
2 stars 2 forks source link

chore: update internal Node.js function call #4

Closed BridgeAR closed 5 years ago

BridgeAR commented 5 years ago

This updates the call to _resolveLookupPaths. It returns a string by default since Node.js v8 when called with a third truthy argument. The backwards compatible return value should change soon, so detect what return type is used and handle both cases.

Refs: https://github.com/nodejs/node/pull/26983

BridgeAR commented 5 years ago

@ofrobots @kjin @vmarchaud PTAL

vmarchaud commented 5 years ago

@BridgeAR Thanks for taking the time to make the PR but this module isn't used anymore, i will deprecate it