search

keyrunHORNET / date_picker_converter

Nepali Date Picker with Date conversion from BS to AD and vice-versa
Apache License 2.0
36 stars 23 forks source link

Nepali year only goes until 2000 #12

Closed jjongko closed 5 years ago

jjongko commented 5 years ago

Hi I was trying this library on a Nursing app we were making for Nurse Association of Nepal, however, the nurses were complaining that the year only goes to 2000, apparently they were profiling a very old person. When they tried using the AD date, the converter failed. Looking at some online date converters the date went below 2000 so I guess that was the issue. Looking at the source code, it seems to be a hard limit that was put in. Would it be possible to lower the min date? I've seen some other converters go to 1970 though i'm not sure how hard that would be to incorporate

keyrunHORNET commented 5 years ago

I will look into it and let you know as soon as possible.

On Thu, Jan 24, 2019, 20:19 jjongko <notifications@github.com wrote:

Hi I was trying this library on a Nursing app we were making for Nurse Association of Nepal, however, the nurses were complaining that the year only goes to 2000, apparently they were profiling a very old person. When they tried using the AD date, the converter failed. Looking at some online date converters the date went below 2000 so I guess that was the issue. Looking at the source code, it seems to be a hard limit that was put in. Would it be possible to lower the min date? I've seen some other converters go to 1970 though i'm not sure how hard that would be to incorporate

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/keyrunHORNET/date_picker_converter/issues/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AKna4V6IU-d_1NXW0VSzhDXN5Ma9jOtuks5vGcSHgaJpZM4aQ_lL .

jjongko commented 5 years ago

This was the table data that I saw that went to 1970, not sure if its useful though

https://github.com/bahadurbaniya/Date-Converter-Bikram-Sambat-to-English-Date/blob/master/src/main/java/np/com/converter/date/nepali/Lookup.java

keyrunHORNET commented 5 years ago

Link you just provided is the solution. I just need some time to reflect that in code. And i really am in hectic and busy schedule right now.

If you have some time, like a month, i will update it for you. Or you can help me by changing it yourself and making a pull request.

All you have to do is update HashMap in DateConverter file and change minimum and maximum date in picker.

On Thu, Jan 24, 2019, 20:32 jjongko <notifications@github.com wrote:

This was the table data that I saw that went to 1970, not sure if its useful though

https://github.com/bahadurbaniya/Date-Converter-Bikram-Sambat-to-English-Date/blob/master/src/main/java/np/com/converter/date/nepali/Lookup.java

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/keyrunHORNET/date_picker_converter/issues/12#issuecomment-457222601, or mute the thread https://github.com/notifications/unsubscribe-auth/AKna4ZRyDZVdyC531i1bH1nFTwTDylXyks5vGcd3gaJpZM4aQ_lL .

jjongko commented 5 years ago

I updated the hashmap and the limit ranges. However, the startWeekDayMonthMap has no data for 1970-1999 since I don't know what goes there. I was hoping it wasn't called anywhere but it looks like it is

keyrunHORNET commented 5 years ago

startweekdaymonthmap is nothing but a weekday of 1st day of every Nepali month in conversion range. value range from 1-7 indicating sunday-saturday.

jjongko commented 5 years ago

Yes... but how will I get that information? Sounds like I would need to input 30x12 number of 1st day of each month in an online nepali calendar?

jjongko commented 5 years ago

Ok I wrote a script to get all the start of month days from https://www.ashesh.com.np/nepali-date-converter.php for each month from 1970 to 1999 and for 2000 (for verification with the original code)

jjongko commented 5 years ago

Ok it looks like I got it to work

keyrunHORNET commented 5 years ago

Can you push the code?

On Wed, Feb 6, 2019, 20:14 jjongko <notifications@github.com wrote:

Ok it looks like I got it to work

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/keyrunHORNET/date_picker_converter/issues/12#issuecomment-461042471, or mute the thread https://github.com/notifications/unsubscribe-auth/AKna4cuihKfjyeWrmc-x_8FMKJwL1ulLks5vKubSgaJpZM4aQ_lL .

jjongko commented 5 years ago

not too familiar with this system, I just downloaded the entire project. I can send you the 2 files I edited if you want

keyrunHORNET commented 5 years ago

Sure.

On Thu, Feb 7, 2019, 16:30 jjongko <notifications@github.com wrote:

not too familiar with this system, I just downloaded the entire project. I can send you the 2 files I edited if you want

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/keyrunHORNET/date_picker_converter/issues/12#issuecomment-461370697, or mute the thread https://github.com/notifications/unsubscribe-auth/AKna4bGXWl2fEmgZExRyrIcuIgJy9GGPks5vLAPDgaJpZM4aQ_lL .