keys-pub / app

Key management is hard
https://keys.pub
Other
126 stars 4 forks source link

Windows: Failed to install symlink #14

Closed mkody closed 4 years ago

mkody commented 4 years ago

I tried to install it and at its first run, I get this.
v0.0.39 downloaded from the releases, Windows 10 Pro 1903.
With the command line I get the timed out waiting for pid message too.

image

gabriel commented 4 years ago

Thanks for submitting the issue, sorry it isn't working for you.

You said you installed the command line, was this via scoop?

If you run keysd does it show an error?

(You may need to run keys stop to stop an existing keysd if it is already running.)

graphixillusion commented 4 years ago

Same error for me too. Windows 10 1909, installed using .msi downloaded from the website. Run as administrator doesn't help either.

mkody commented 4 years ago

Yes I installed the CLI from scoop. Running keysd returns me this

PS C:\Users\mkody> keysd
time="2020-05-08T23:50:25.7056157+02:00" level=info msg="Version: 0.0.39 fa25a4ec201c3ceaafbc7add19751e72df2ce505 2020-05-05T22:22:26Z"
time="2020-05-08T23:50:25.9016157+02:00" level=info msg="Log level: info"
time="2020-05-08T23:50:25.9036171+02:00" level=info msg="Keyring (default)"
time="2020-05-08T23:50:25.9036171+02:00" level=info msg="Keyring, using wincred"
Élément introuvable.
gabriel commented 4 years ago

I'm having trouble reproducing on my windows machine.. Is there anything non standard about your Windows install that might cause the Windows Credential API to not be available?

graphixillusion commented 4 years ago

@gabriel is there any other way to check if Windows Credential API is working correctly?

gabriel commented 4 years ago

Oh you know, maybe antivirus software is preventing that. Do you mind sharing which antivirus software you might have?

graphixillusion commented 4 years ago

@gabriel i'm using the Windows built in, Windows Defender

gabriel commented 4 years ago

Oh wait.. does it fail if you have both scoop and the app installed?

gabriel commented 4 years ago

There might be 2 issues here... A wincred issue and a scoop+app conflict issue.

The scoop confict issue can be resolved with scoop uninstall keys and killing keysd.exe process. (I'll have a better fix out at some point.)

Wincred issue I'm still investigating.

mkody commented 4 years ago

On my side, it was already happening with the app only. I don't have anything other than the Windows Defender on my machine too.

Except enabling the Linux subsystem and having docker running, I think I didn't do much to my Windows.

graphixillusion commented 4 years ago

@gabriel Yep, the error occurs with the only app installed (msi one). I've also tried to uninstall the msi's one and install the cmdline version using scoop: same error as above. I'm just try to guessing: my os is with italian language, the language of the other user seems french: it could be a language related error?

gabriel commented 4 years ago

@graphixillusion @mkody what happens if you run keysd.exe?

(keysd is in ~/AppData/Local/Programs/keys/resources/bin)

gabriel commented 4 years ago

If you have go installed can you run this:

go get github.com/keys-pub/keys/keyring/cmd/keyring
`go env GOPATH`/bin/keyring

This will list your keyring IDs (using windows credential)... does this throw an error?

graphixillusion commented 4 years ago

@gabriel keysd output:

time="2020-05-10T03:38:37.8293049+02:00" level=info msg="Version: 0.0.43 22cc59110c810f4707e26f11908c729c51e8e06f 2020-05-09T21:24:41Z"
time="2020-05-10T03:38:38.1411127+02:00" level=info msg="Log level: info"
time="2020-05-10T03:38:38.1421119+02:00" level=info msg="Keyring (default)"
time="2020-05-10T03:38:38.1431106+02:00" level=info msg="Keyring, using wincred"
Unable to find element.

go get github.com/keys-pub/keys/keyring/cmd/keyring <--- it compiles "keyring.exe" inside GOPATH/bin

when i launch it, nothing happens, blank line. One question: the " ` " char in your command is the markdown element for the code? Becouse Windows cmd.exe doesn't recognize that char, the command i used to launch is: go env gopath\bin\keyring (or manually launch keyring.exe directly from the gopath\bin folder).

gabriel commented 4 years ago

I figured it out, fix coming soon.

gabriel commented 4 years ago

This should be fixed in https://github.com/keys-pub/app/releases/tag/v0.0.45.

It was an i18n issue... the wincred package was checking error strings instead of codes, so was failing on non-english locales, see https://github.com/keys-pub/wincred/pull/1 for more details.

So @graphixillusion it was totally a language related error, you called it :)

I had to install a French version of Windows to reproduce (an English version with French language packs though wouldn't reproduce).

Anyway thanks for helping out.