keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support
https://keyshade.xyz
Mozilla Public License 2.0
165 stars 87 forks source link

Create S3 client provider #120

Closed rajdip-b closed 3 months ago

rajdip-b commented 7 months ago

Description

We would like to use S3 compatible storage to store our BLOB data. For this, we first need to create a provider that will give us the required s3 client.

Solution

Note that, we want to load the minio service conditionally, that is, if any of the environmental variables are not specified, we don't want to initialize it. To accomplish this, you can maintain a flag in the minio service file. Before calling any upload/fetch/delete function, you can check if the flag is set to true. If not, just skip the operation.

Additional context

References:

rajdip-b commented 6 months ago

S3 Support

HarshPatel5940 commented 4 months ago

/attempt

github-actions[bot] commented 4 months ago

Assigned the issue to you!

rajdip-b commented 4 months ago

@HarshPatel5940 hey bro, this issue is now slightly updated. There's a providers module. Please add the s3 stuff in that module and export it the way we are exporting redis. You can take redis.provider.ts as a reference.

HarshPatel5940 commented 4 months ago

@HarshPatel5940 hey bro, this issue is now slightly updated. There's a providers module. Please add the s3 stuff in that module and export it the way we are exporting redis. You can take redis.provider.ts as a reference.

Ok, rajdip. 👍 I will look into it.

rajdip-b commented 3 months ago

:tada: This issue has been resolved in version 1.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: