API: IP Blacklisting on workspaces

keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support

https://keyshade.xyz

Mozilla Public License 2.0

230 stars 108 forks source link

API: IP Blacklisting on workspaces #127

Open rajdip-b opened 9 months ago

rajdip-b commented 9 months ago

Description

Add a feature that will enforce security of the workspaces by blocking users from accessing it if their IP addresses are in the blacklist. We would support both IPv4 and IPv6 address blacklisting. Workspace administrators would be able to update the blacklist of the workspaces.

Solution

Update the workspace schema to hold a list of blacklisted IP addresses
Create a guard that will run only if: the user is authenticated, they are trying to access a workspace or related resources. If the user's IP address is blacklisted, we don't allow them to access it by throwing an unauthorized exception

rajdip-b commented 9 months ago

IP Blacklisting on workspaces

Z-xus commented 4 months ago

/attempt for fosshack

github-actions[bot] commented 4 months ago

Assigned the issue to @Z-xus!

MelloB1989 commented 4 months ago

Hey I am Kartik Deshmukh. I am one of the participants in the FOSS Hack. We want to contribute to this issue and I feel confident my contribution will help! /attempt

rajdip-b commented 4 months ago

@MelloB1989 hello! Please make sure that no one's assigned to the issue before you try to get assigned since that's against the guidelines for this hackathon.

Z-xus commented 4 months ago

Hi, I have created the guard and schema, I wanted to know which controller methods require the guard and also do you need another controller method to update the blacklistedIps[] or just a service method?

rajdip-b commented 4 months ago

Hi, I have created the guard and schema, I wanted to know which controller methods require the guard and also do you need another controller method to update the blacklistedIps[] or just a service method?

We would need a separate guard that will work on every endpoint related to workspaces. And yes, we want to allow another endpoint that would allow workspace admins to update the blacklisted IP addresses. Ideally, this should be in workspace controller.

rajdip-b commented 4 weeks ago

@Z-xus you still on this?

Z-xus commented 2 weeks ago

Sorry, I loved working here but I can't spare the time to do so anymore..

rajdip-b commented 2 weeks ago

Ah man, that's sad. It's okay. We would be glad to have you back dropping more PRs when you can! Appreciate all the help that you have been so far.