Add docker build and run commands to `package.json`

keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support

https://keyshade.xyz

Mozilla Public License 2.0

118 stars 55 forks source link

Add docker build and run commands to `package.json` #257

Closed rajdip-b closed 3 weeks ago

rajdip-b commented 4 weeks ago

Description

Adding the docker commands to package.json will help developers to better test their builds.

Solution

Add the following scripts to the root package.json:

docker:build:api
docker:run:api
docker:build:web
docker:run:web
docker:build:platform
docker:run:platform

vr-varad commented 3 weeks ago

@rajdip-b for clarification what would be the web-image name?

rajdip-b commented 3 weeks ago

Okay so you can use this pattern:

ks-web
ks-platform
ks-api

vr-varad commented 3 weeks ago

the platform doesn't have a docker file @rajdip-b

rajdip-b commented 3 weeks ago

Ah shoot, would you mind adding one? Ideally, you would just need to copy and paste the web Dockerfile and modify it.

@kriptonian1 I don't think we need to do anything else?

P.S. @vr-varad it is okay if you would just like to put up a pr for web and api. We can open another issue for platform.

kriptonian1 commented 3 weeks ago

Ah shoot, would you mind adding one? Ideally, you would just need to copy and paste the web Dockerfile and modify it.

@kriptonian1 I don't think we need to do anything else?

P.S. @vr-varad it is okay if you would just like to put up a pr for web and api. We can open another issue for platform.

that should be good to go, but maybe if it can be optimized then it will be better

rajdip-b commented 2 weeks ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: