PLATFORM: Add `Dockerfile` to `platform` - Githubissues

keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support

https://keyshade.xyz

Mozilla Public License 2.0

118 stars 55 forks source link

PLATFORM: Add `Dockerfile` to `platform` #259

Open rajdip-b opened 3 weeks ago

rajdip-b commented 3 weeks ago

Description

We would like to containerize the platform package. Add a dockerfile to this package.

Solution

Add a Dockerfile in /apps/package. You can refer to this
Add two scripts in root package.json: docker:build:platform and docker:run:platform. Refer to #258

DhairyaMajmudar commented 1 week ago

Hi, @rajdip-b this seems to be an interesting issue to solve can you pls. mind assigning me. In past I have exp. of dockerising JSON Schema Org. website which is built on the similar tech stack keyshade is built on Thank you : )

rajdip-b commented 1 week ago

We would be glad to @DhairyaMajmudar! All the best!

DhairyaMajmudar commented 1 week ago

We would be glad to @DhairyaMajmudar! All the best!

Thanks will give my best

DhairyaMajmudar commented 1 week ago

Also @rajdip-b can you pls. also add this issue in the FossHack issue board.

rajdip-b commented 1 week ago

Sure thing boss!

DhairyaMajmudar commented 1 week ago

Thanks, man, you are awsm =)

DhairyaMajmudar commented 1 week ago

@rajdip-b the docker file is ready but I am facing a lot of build failures due to type-checks, Shall I incorporate the changes in the same PR or open a new issue?

EDIT: Total type errors in platform folder, checked using script tsc --noEmit

rajdip-b commented 1 week ago

I would say, if it's avoidable, then just let it be like this for now. We can always iterate over this. But if this PR requires this type check to pass, then you can put up the implementation in the same PR. Totally depends upon how you want it to be done!