refactor(api): Update return type while fetching secrets and variables

Ritika1705 commented 3 weeks ago

Description

Updated return type while fetching secrets and variables

Fixes #261

Dependencies

Mention any dependencies/packages used

Future Improvements

Mention any improvements to be done in future related to any file/feature

Mentions

Mention and tag the people

Screenshots of relevant screens

Add screenshots of relevant screens

Developer's checklist

[ ] My PR follows the style guidelines of this project
[ ] I have performed a self-check on my work

If changes are made in the code:

[ ] I have followed the coding guidelines
[ ] My changes in code generate no new warnings
[ ] My changes are breaking another fix/feature of the project
[ ] I have added test cases to show that my feature works
[ ] I have added relevant screenshots in my PR
[ ] There are no UI/UX issues

Documentation Update

[ ] This PR requires an update to the documentation at docs.keyshade.xyz
[ ] I have made the necessary updates to the documentation, or no documentation changes are required.

Ritika1705 commented 3 weeks ago

Format

rajdip-b commented 3 weeks ago

Format

This looks perfect!

Ritika1705 commented 3 weeks ago

@rajdip-b , done!!

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.65%. Comparing base (ce50743) to head (3de8cd6). Report is 26 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #264 +/- ## =========================================== - Coverage 91.71% 90.65% -1.06% =========================================== Files 111 113 +2 Lines 2510 2750 +240 Branches 469 526 +57 =========================================== + Hits 2302 2493 +191 - Misses 208 257 +49 ``` | [Flag](https://app.codecov.io/gh/keyshade-xyz/keyshade/pull/264/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keyshade-xyz) | Coverage Δ | | |---|---|---| | [api-e2e-tests](https://app.codecov.io/gh/keyshade-xyz/keyshade/pull/264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keyshade-xyz) | `90.65% <100.00%> (-1.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keyshade-xyz#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rajdip-b commented 2 weeks ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

keyshade-xyz / keyshade