API: Replace for loop with array indexing while decrypting secrets during bulk fetch

keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support

https://keyshade.xyz

Mozilla Public License 2.0

196 stars 96 forks source link

API: Replace for loop with array indexing while decrypting secrets during bulk fetch #265

Closed rajdip-b closed 3 months ago

rajdip-b commented 3 months ago

Description

When we fetch secrets by a project ID, we only include the latest version of the secret. Currently, while decrypting the value, we are unnecessarily running a while loop. We would like to replace this with just const version = secret.versions[0]

https://github.com/keyshade-xyz/keyshade/blob/020bbf642335fb98db59e83ec722f24490f36d03/apps/api/src/secret/service/secret.service.ts#L496

anudeeps352 commented 3 months ago

/attempt I'd like to work on this issue.

github-actions[bot] commented 3 months ago

Assigned the issue to you!

rajdip-b commented 3 months ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: