search

keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support
https://keyshade.xyz
Mozilla Public License 2.0
118 stars 55 forks source link

Update `deploy` workflow to be triggered when a release happens #274

Open rajdip-b opened 2 weeks ago

rajdip-b commented 2 weeks ago

Description

Currently, whenever we push code to the main branch, release workflow is triggered. It runs the semantic release plugin and creates a github release for the codebase.

Along with that, deploy workflow is also run that will (currently) build the web image and push it to AWS ECR.

While this is okay, we would like to have more control over how we tag our images.

https://github.com/keyshade-xyz/keyshade/blob/3c042cfbde03434c4180af50f898cf192bbfe1c8/.github/workflows/deploy-web.yml#L36

Currently, the tags are the 6-letter SHA of the commit hash. We would like to refactor it to the release version.

Proposed solution

We would like the deploy workflow to be triggered whenever a release is made. And then, we would like to tag our image with the release version and push it.

amkarn258 commented 2 weeks ago

Hi @rajdip-b ,

Can you please assign this issue to me? I'm new to open source and would like to help.

rajdip-b commented 2 weeks ago

Hey @amkarn258! We would be glad to do so. Could you wait up for a while? Since this issue is a part of FOSS hack. You would need to go through some registration process, which we are still unsure about! I would surely ping you back as soon as I get to know the steps!

amkarn258 commented 2 weeks ago

Sure, would be happy to help

aialok commented 1 week ago

Hey, I would love to work on this issue. I have experience with github action and workflows : )

rajdip-b commented 1 week ago

Sure thing @aialok! Give it a shot.

rajdip-b commented 1 week ago

@aialok @amkarn258 this issue is a part of FOSS hack. To attempt this, you would need to register with them first! https://fossunited.org/fosshack/2024

aialok commented 1 week ago

Yes, I already register for the hackathon. I think I need to wait till 27 July to make PR. As it stated on portal : )

Thank you @rajdip-b

rajdip-b commented 1 week ago

Awesome!