Closed rajdip-b closed 4 months ago
β±οΈ Estimated effort to review: 2 π΅π΅βͺβͺβͺ |
π§ͺ No relevant tests |
π No security concerns identified |
β‘ No key issues to review |
Category | Suggestion | Score |
Best practice |
Add a step to install dependencies before starting development___ **Include a step to install dependencies before starting the development process to avoidmissing dependencies issues.** [docs/contributing-to-keyshade/running-things-locally/running-the-cli.md [7]](https://github.com/keyshade-xyz/keyshade/pull/329/files#diff-221720c0ac7b87b993eca0a3bb505708e764cc6615a927f013dbc5e5bbcc3546R7-R7) ```diff +- Install dependencies: + ```bash + pnpm install + ``` - Start developing the code ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: Including a step to install dependencies is crucial to ensure that all necessary packages are available before development begins, preventing potential issues. | 8 |
Maintainability |
Add a note to ensure correct import of the
___
**Add a note to ensure that the | 7 |
Enhancement |
Add a brief description of the
___
**Add a brief description of the | 6 |
PR Type
Documentation, Enhancement
Description
--overwrite
option in the InitCommand.SUMMARY.md
to include links to new CLI documentation sections and reordered some sections for better organization.Changes walkthrough π
init.command.ts
Add default value for `--overwrite` option in InitCommand
apps/cli/src/commands/init.command.ts
--overwrite
option in the CLI command.SUMMARY.md
Update SUMMARY.md to include CLI documentation
docs/SUMMARY.md
README.md
Add CLI link to design documentation README
docs/contributing-to-keyshade/design-of-our-code/README.md - Added a link to the new CLI documentation.
cli.md
Add detailed design documentation for CLI
docs/contributing-to-keyshade/design-of-our-code/cli.md
practices.
web.md
Enhance web design documentation with descriptions and formatting
docs/contributing-to-keyshade/design-of-our-code/web.md
README.md
Update local running instructions to include CLI and Web
docs/contributing-to-keyshade/running-things-locally/README.md - Added links to new CLI and Web running instructions.
running-the-cli.md
Add instructions for running the CLI locally
docs/contributing-to-keyshade/running-things-locally/running-the-cli.md - Created a new document detailing how to run the CLI locally.