keyshade-xyz / keyshade

Realtime secret and configuration management tool, with the best in class security and seamless integration support
https://keyshade.xyz
Mozilla Public License 2.0
208 stars 105 forks source link

API: Add pagination metadata #336

Closed rajdip-b closed 3 months ago

rajdip-b commented 4 months ago

Description

Add the following fields when returning paginated response in every module:

We want the computation to be done in the service classes.

Solution

Objectives

This issue is the parent issue. Below you will find a list of issues that relate to this. These issues encompass the scope of change in every module:

muntaxir4 commented 4 months ago

This will cause the return type of affected methods to be Objects such that to hold those required fields right? And currently these methods return Arrays of Objects. The new result would be like { items : [...], metadata:{...}}

rajdip-b commented 4 months ago

Exactly!

muntaxir4 commented 4 months ago

Can you assign me the whole list of issues? As of now I have implemented locally for the Project module.

rajdip-b commented 4 months ago

Hey @muntaxir4! Yeah, I think I can do that. Just note that, you would need to make the commits and put up the PR in the hackathon window :)