fix(platform): Platform types fixes

DhairyaMajmudar commented 2 months ago

User description

Description

platform types fixes

Fixes #371

Dependencies

Update the typescript version to 5.3.3
Adding @types/dayjs-precise-range in platform package.json

Future Improvements

N/A

Mentions

@rajdip-b

Screenshots of relevant screens

Screenshot from 2024-07-27 11-43-22

Developer's checklist

[x] My PR follows the style guidelines of this project
[x] I have performed a self-check on my work

If changes are made in the code:

[x] I have followed the coding guidelines
[x] My changes in code generate no new warnings
[ ] My changes are breaking another fix/feature of the project
[ ] I have added test cases to show that my feature works
[x] I have added relevant screenshots in my PR
[ ] There are no UI/UX issues

Documentation Update

[ ] This PR requires an update to the documentation at docs.keyshade.xyz
[ ] I have made the necessary updates to the documentation, or no documentation changes are required.

PR Type

enhancement, dependencies

Description

Added @types/dayjs-precise-range to devDependencies in apps/platform/package.json.
Updated typescript version from ^4.5.3 to ^5.3.3 in apps/platform/package.json.

Changes walkthrough 📝

Relevant files

Dependencies

package.json

Update TypeScript version and add new type definitions

apps/platform/package.json

Added @types/dayjs-precise-range to devDependencies.

Updated typescript version from ^4.5.3 to ^5.3.3.

+2/-1

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

codiumai-pr-agent-free[bot] commented 2 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No key issues to review

codiumai-pr-agent-free[bot] commented 2 months ago

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Pin the version of `@types/dayjs-precise-range` to a specific release ___ Consider pinning the version of `@types/dayjs-precise-range` to avoid potential breaking changes that could occur with minor version updates. Using a specific version helps ensure consistent behavior across environments and deployments. [apps/platform/package.json [54]](https://github.com/keyshade-xyz/keyshade/pull/374/files#diff-ccbe95f6e6aa4e3266a5e9cf1bcfee8f323da5b0be41f8cab6e3f8ab98d0ddcdR54-R54) ```diff -"@types/dayjs-precise-range": "^1.0.5", +"@types/dayjs-precise-range": "1.0.5", ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 9 Why: Pinning the version of `@types/dayjs-precise-range` helps ensure consistent behavior across different environments and deployments, reducing the risk of unexpected issues due to minor version updates.	9
Maintainability	Pin the `typescript` version to a specific minor release ___ Update the `typescript` version to a specific minor release instead of using the caret (^) version range. This can help in avoiding unexpected issues due to new minor versions which might introduce breaking changes. [apps/platform/package.json [63]](https://github.com/keyshade-xyz/keyshade/pull/374/files#diff-ccbe95f6e6aa4e3266a5e9cf1bcfee8f323da5b0be41f8cab6e3f8ab98d0ddcdR63-R63) ```diff -"typescript": "^5.3.3" +"typescript": "5.3.3" ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 9 Why: Pinning the `typescript` version to a specific minor release helps avoid unexpected issues that might arise from new minor versions introducing breaking changes, thus improving maintainability.	9

DhairyaMajmudar commented 2 months ago

Shall I also puch the changes done in pnpm-lock file ?

rajdip-b commented 2 months ago

Yes! We would need the lockfile changes.

rajdip-b commented 2 months ago

@DhairyaMajmudar there's something that I would be glad if you can do. I see that these errors were related to typescript. Now that I see, all the different packages are using their own version of typescript. We don't want that. Could you please move out typescript to the root package.json dev dependency? And delete typescript from all the other package.json files?

DhairyaMajmudar commented 2 months ago

@DhairyaMajmudar there's something that I would be glad if you can do. I see that these errors were related to typescript. Now that I see, all the different packages are using their own version of typescript. We don't want that. Could you please move out typescript to the root package.json dev dependency? And delete typescript from all the other package.json files?

sounds correct, let's do this 🚀

DhairyaMajmudar commented 2 months ago

First time in life changing 5 package.json files at same time 💀

Screenshot from 2024-07-27 12-18-41

rajdip-b commented 2 months ago

xD

keyshade-xyz / keyshade